Chrome. Nothing appears in the browser console when I search for ‘ICD’, but this appears when I load the edit concept page:
This made sense when we were loading all the sources at once. We don’t anymore. I could see us adding a bestMatch sort type to the endpoint though.
Version? 
For sanity, I’m seeing a 401 before that, please refresh to make sure you are logged in. Let me try this in a couple other browsers.
New issue:
Edit dictionary view only has a submit button, should also have a cancel button. If the back button is to be used as a cancel button, then there should be a warning of unsaved changes before leaving the screen.
When adding a new concept (pick an existing concept), the screen needs to change to show that you are in a concept adding role and not just a concept viewing role. I got lost and thought I was trying to add when I was looking at my existing concepts.
When adding an existing concept to a dictionary, it is not clear what clicking on the concept should do. It actually views the concept, the only way to add it is to click on the three dots and select add. There should be a way to add directly from the search result, and another way to add from the view concept screen.
Same goes for selection. I should not require two clicks to select a row. Clicking on the row should select the row. Control-click should do multiple rows, etc.
1 Like
Version 80.0.3987.116 (Official Build) (64-bit). After a refresh, I don’t get those console errors. But I don’t see more sources beyond ‘CIEL’ and ‘PIH’.
2 Likes
Some additional issues:
-
I was thought it was possible to delete a concept from a collection/dictionary if it has not yet been published. I only see the ability to edit a concept.
-
Language should default to default language for all new entries (name, description, etc.)
-
Default in language should default to YES on all initial entries into a category field, and then all additional rows with the same language in a category should default to NO.
-
Source selection list is restricted to two rows on Mapping object. Can it extend to the whole window?
More coming (sorry this was in my draft state for a week)!
1 Like
I have created 3 tickets in the next sprint (26) based on previous testing on OCL for OpenMRS Version 2.
These are not major problems. Only the 1st one would be useful for usability.
@akanter Can you create tickets for the issues you discovered in V2?
Afraid I don’t have time to create tickets… I can review them, but perhaps @herbert24 can. Thanks
Just tested the new version 2 build pointing to demo. When I was adding new concepts to the dictionary I changed from CIEL to PIH and back again. Doing this changes the behavior of the back arrow at the top, as this now backs up through the changing sources. It needs to ALWAYS go back to viewing the concepts in the dictionary I am adding.
Also, we need to be able to search across all public sources (or those I have access to) when adding a new concept. I should not be forced to switch the source I am searching at the top.
i think switching just helps you to search a single source at a time.@karuhanga whats your take on this?
There are two use cases. Filtering by source should be possible from the search page. However, if I am looking for a concept from any trustworthy source, it is tedious to keep switching and repeating the search. I think it is more intuitive to have the search page default to a source, but then allow you to remove the filter and search everything or another source.
1 Like
It was never possible to remove a custom concept. Only retire it. Should this be possible and does it not lead to a situation where an existing concept is ‘hidden’ from the user?
More light on this please, could this be related to the issue Ellen is facing?
I agree with this. Added a ticket.
The idea is that if I created a custom concept and have not yet published/released it, that I should be able to delete it. Once released, it can only be retired.
Not sure about the second item.
@akanter the API does not support deleting a concept from a source. We can delete it from the collection, but it will still be available in the source. This can be done, but that would mean that the concept name and id cannot be reused. I think this will create confusion, i.e a user tries to create a concept of the same name but is told the name has been used, yet they cannot see where.
Does this make sense?
Just logged into QA and tried to create a dictionary Andy Test and it failed without a warning. The submit button didn’t do anything.
Also, when i tested DEMO, and added a concept from CIEL that required dependent concepts (984-Immunizations) and the dependent concepts did not come over. I was not able to test in QA.
The underscore was the problem here. Added this validation.
Fixed this and added a test.
1 Like
When testing an issue around mapping, I realized that there is no way to create an external mapping (ICD10WHO, SNOMED, etc.) because it requires an existing concept to map to. Internal concepts maps should require selection of the concept. External maps should simply capture alphanumeric without validation. This is a show-stopper, required for MVP. @karuhanga
