then I change visibility to Private, and the owner dropdown changes to this:
It should not show two options where thereâs only real option
It shouldnât change the text for no apparent reason.
I do not think this is an MVP bug, though Iâm concerned, especially given the next thing I didâŠ
Then I did something random (closed that dictionary, clicked New Dictionary, then Cancel, then open the first dictionary again and click Edit) and now it looks like it lost a lot of values:
this is an MVP bug. It seems like state is being improperly shared across different instances of opening this form, and this makes me concerned about the underlying code.
About creating concepts:
I added âReasons for Referralâ to my dictionary. First it does a nice-looking thing where it shows that itâs going to add 39 dependent concepts, then the number goes up to 42. But then it just says âFinalizingâ and it waits there for a long time.
That text is not helpful. I would change the initial text to say âFound X dependent concepts to addâ and then âAdding and dependent concepts. This may take several minutes. DO NOT NAVIGATE AWAY FROM THE APPLICATION UNTIL THIS IS COMPLETE.â
I notice that I was able to navigate away from the Add screen and it seemed like things kept working, which is nice. (If this is not the case, then we need to prevent navigating away.)
I left the tab and when I came back to it the message was gone and I didnât see any of the new concepts in my dictionary. I did a browser refresh and then I could see them. (This is MVP, that when the long-running task completes and youâre looking at the dictionary, it must refresh to show you the new state.)
At this point one of my concepts is being displayed with a French name, and everything else with English:
I try to create a concept with the same name as an existing concept that I already added from CIEL (âNight Blindnessâ) and the UI never gives me any indication that there was an error. (It showed a yellow message, then refreshed the concept list.). The result was that if I look on the back end my Source did have a concept created, but this was not added to my Collection.
I think this is an MVP to fix (i.e. donât want to ever end up in the state where there is some concept in our Source, but not in the Collection.)
Or did we already discuss this and decide it was too hard to fix now?
The additional confusing thing for the user is that because of this I have used up an OCL ID, though I cannot see this in the new UI. So if I try to create my next concept with id 1 (since thereâs nothing with that ID in the collection yet) I get a different error message thatâs hard to interpret, and it disappears after ~5 seconds, which wouldnât be long enough if I didnât already know whatâs going on. And then whatever I entered is lost. (âAn error occurred when creating a concept. Concept with this Mnemonic and Parent id already exists. for allâ)
Darius, there are issues with OCL showing the French as the preferred name in the UI. I donât know why we do the same if we are viewing our data. If we are only viewing what is shown in OCL, then the same issue is there too.
Since we canât cross validate across collections and sources, the way I see it, we have two options here;
Check the collection for if a concept with such a name exists(we canât do this right now, because a concept can have multiple names and by design, we canât do something like query all names in a collection)
I also thought that there were insufficient sources available for mapping. Do we need to load the database that we were using for QA with this code, or better yet, move the code to the QA database?
We had a bug where we were to order the concept sources based on a preference. Sounds like we need to do something with the API results before displaying.