IDGEN-42 Ticket progress tracker

platform-22
Tags: #<Tag:0x00007efdb4c970d0>

(Samuel Male) #1

Extending discussion from Pending tickets for Platform 2.2, I have just started this thread to keep track of progress on the remaining ticket which currently being worked on by @tendomart.

@tendomart feel free to post blockers, progress and related resources here. The major usecase for this to ensure this ticket gets fixed ASAP.

~Samuel


(Samuel Male) #2

@tendomart should we expect a commit(PR) like atleast later this Wednesday?


(tendo kiiza Martyn) #3

Sorry not been online whole day but will do a commit in a few hours from now.


(Samuel Male) #4

Just a follow up comment, should we expect a PR maybe late this week @tendomart :smile:


(tendo kiiza Martyn) #5

@samuel34 a commit atleast.

@dkayiwa am just wondering if on top of

  • IdentifierPoolResourceHandler

-RemoteIdentifierSourceResourceHandler

-SequentialIdentifierGeneratorResourceHandler

-IdentifierSourceResourceTest

a SequentialIdentifierGeneratorController should miss out


(Daniel Kayiwa) #6

@tendomart I do not understand your question.


(tendo kiiza Martyn) #7

@dkayiwa i have succeeded bringing back

-IdentifierPoolResourceHandler

-RemoteIdentifierSourceResourceHandler

-SequentialIdentifierGeneratorResourceHandler

-IdentifierSourceResourceTest(existed) as per https://issues.openmrs.org/browse/IDGEN-42

been thinking of exposing SequentialIdentifierGenerator Resource by also introducing a SequentialIdentifierController.Is this not re-inventing the wheel ?

but still checking to see if that was handled via -IdentifierSourceController


(Daniel Kayiwa) #8

Do what you think is best as per your judgement and raise a pull request which we shall review and comment as needed. Remember to bring back the tests too.


(tendo kiiza Martyn) #9

@dkayiwa alright thanks.


(Irene Nyakate) #10

Hello @tendomart I hope you are pushing on well with this issue.


(Samuel Male) #11

@tendomart any hopes of making a PR today?


(Irene Nyakate) #12

@tendomart may be offline


(tendo kiiza Martyn) #13

Hopefully Tomorrow… Sorry it’s stretched this far…


(Samuel Male) #14

Just a reminder to @tendomart


(tendo kiiza Martyn) #15

@samuel34 yeah sure thanks !


(tendo kiiza Martyn) #16

@dkayiwa , @samuel34 i did a commit at https://github.com/tendomart/openmrs-module-idgen/commit/deeff70900538a0a3adbec380e4869187f0fb263 You guys can take a look at it

cc. @c.antwi cc. @irenyak1


(Cynthia Antwi) #17

Thanks will do so.

Regards

Cynthia