samuel34
(Samuel Male)
November 7, 2018, 9:27am
1
Extending discussion from Pending tickets for Platform 2.2 , I have just started this thread to keep track of progress on the remaining ticket which currently being worked on by @tendomart .
@tendomart feel free to post blockers, progress and related resources here. The major usecase for this to ensure this ticket gets fixed ASAP.
~Samuel
1 Like
samuel34
(Samuel Male)
November 7, 2018, 9:38am
2
@tendomart should we expect a commit(PR) like atleast later this Wednesday?
tendomart
(tendo kiiza Martyn)
November 7, 2018, 8:15pm
3
Sorry not been online whole day but will do a commit in a few hours from now.
samuel34
(Samuel Male)
November 8, 2018, 7:02pm
4
Just a follow up comment, should we expect a PR maybe late this week @tendomart
tendomart
(tendo kiiza Martyn)
November 8, 2018, 8:19pm
5
@samuel34 a commit atleast.
@dkayiwa am just wondering if on top of
IdentifierPoolResourceHandler
-RemoteIdentifierSourceResourceHandler
-SequentialIdentifierGeneratorResourceHandler
-IdentifierSourceResourceTest
a SequentialIdentifierGeneratorController should miss out
dkayiwa
(Daniel Kayiwa)
November 8, 2018, 8:28pm
6
@tendomart I do not understand your question.
tendomart
(tendo kiiza Martyn)
November 8, 2018, 8:41pm
7
@dkayiwa i have succeeded bringing back
-IdentifierPoolResourceHandler
-RemoteIdentifierSourceResourceHandler
-SequentialIdentifierGeneratorResourceHandler
-IdentifierSourceResourceTest(existed)
as per https://issues.openmrs.org/browse/IDGEN-42
been thinking of exposing
SequentialIdentifierGenerator Resource by also introducing a SequentialIdentifierController.Is this not re-inventing the wheel ?
but still checking to see if that was handled via
-IdentifierSourceController
dkayiwa
(Daniel Kayiwa)
November 8, 2018, 8:55pm
8
Do what you think is best as per your judgement and raise a pull request which we shall review and comment as needed. Remember to bring back the tests too.
2 Likes
irenyak1
(Irene Nyakate)
November 12, 2018, 2:17pm
10
Hello @tendomart I hope you are pushing on well with this issue.
samuel34
(Samuel Male)
November 13, 2018, 9:32am
11
@tendomart any hopes of making a PR today?
irenyak1
(Irene Nyakate)
November 13, 2018, 11:08am
12
@tendomart may be offline
tendomart
(tendo kiiza Martyn)
November 13, 2018, 5:29pm
13
Hopefully Tomorrow…
Sorry it’s stretched this far…
samuel34
(Samuel Male)
November 14, 2018, 12:31pm
14
Just a reminder to @tendomart
tendomart
(tendo kiiza Martyn)
November 14, 2018, 1:04pm
15
@samuel34 yeah sure thanks !
tendomart
(tendo kiiza Martyn)
November 16, 2018, 2:11pm
16
samuel34
(Samuel Male)
November 18, 2018, 12:47pm
18
Thanks @tendomart for the commit. But why don’t you do your contributions through the Pull Request convention? It’s always module codebase maintainers that use that commit convention!
dkayiwa
(Daniel Kayiwa)
November 18, 2018, 1:06pm
19
Yes he needs to do a pull request.
tendomart
(tendo kiiza Martyn)
November 19, 2018, 5:47am
20
@samuel34 i thought it more convenient and wise to have you guys look at it before i do a PR.But a PR is coming shortly.