dkayiwa
(Daniel Kayiwa)
November 19, 2018, 9:35am
21
Such changes do not appear in our pool of pull requests which we routinely look at. Therefore, always do a pull request.
1 Like
samuel34
(Samuel Male)
November 21, 2018, 9:29pm
22
@tendomart just a reminder on issuing a PR
1 Like
samuel34
(Samuel Male)
November 23, 2018, 7:16am
23
On such a freaky Friday, @tendomart would really wanna raise a PR
irenyak1
(Irene Nyakate)
November 23, 2018, 11:44am
24
How is @tendomart doing, is he able to receive these notifications?
tendomart
(tendo kiiza Martyn)
November 23, 2018, 1:20pm
25
@irenyak1 , @samuel34
Wanted to folks but,my machine is faulty.Fixing it…but updates are this week
I refactored the repo because it was noisy and making some changes as some of my Mock Test Objects are still failing.so am working hard to make them pass so i can effectually raise a PR.
2 Likes
irenyak1
(Irene Nyakate)
November 26, 2018, 8:10am
26
Hello @tendomart how are you doing? was your machine fixed? Should we expect a PR today or tomorrow?
tendomart
(tendo kiiza Martyn)
November 26, 2018, 7:15pm
27
@irenyak1 am fixed Tomorrow hopefully
tendomart
(tendo kiiza Martyn)
November 28, 2018, 9:10pm
28
did a PR at https://github.com/openmrs/openmrs-module-idgen/pull/71 with some errors for @samuel34 's sake… .still fixing the remaining methods.
samuel34
(Samuel Male)
November 28, 2018, 9:14pm
29
Man it looks like your working from the master branch. Did you just forget?
tendomart
(tendo kiiza Martyn)
November 28, 2018, 9:17pm
30
@samuel34 oops yeah, i did.After cleaning the previous commit ,forgot to create a new branch…But look at the changes anyways will change that.
samuel34
(Samuel Male)
November 28, 2018, 9:30pm
31
I wish your work was on a different branch, I would get it locally and efficiently make more changes
tendomart
(tendo kiiza Martyn)
November 28, 2018, 9:35pm
32
let me find a way out.I hope it doesn’t get noisy again.
1 Like
tendomart
(tendo kiiza Martyn)
December 4, 2018, 8:53am
33
@c.antwi @samuel34 forked my branch ,were trying to break it down into smaller tasks to accelerate Release…
1 Like