@judeniroshan, i am actually refining my commits, give me couple of hours and you will see a refined version
Meeting tomorrow!
time: 7pm CEST
@judeniroshan, I am currently working on a customizable starter kit version of openmrs-react-components, I have created a npm package to test out my findings and a gif to explaing the current status.
@judeniroshan, yes are you trying my example repository?
As mentioned in the Readme you will have to use my fork of openmrs-react-components as the example repository conatins new components
@judeniroshan, @mogoodrich Try this!
create-react-app test-app --scripts-version openmrs-react-scripts
This will create a test-app with openmrs-react-components & its dependencies configured!
Repo for above code: https://github.com/beingtmk/create-react-app?organization=beingtmk&organization=beingtmk
Corresponding npm package: https://www.npmjs.com/package/openmrs-react-scripts
I will move my work done until now into this.
I am thinking, i will ask for a terminal argument based on which
- either a example-repo (containing documentation)
- template with minimal or only required configuration (people can just start coding)
The above npm package is installing from published npm package of openmrs-react-components.
So i will keep working on the creating the starter kit version of openmrs-react-components.
There will be two types of starter templates:
- Example Repository
- Minimal Configuration Repository
Also i will move all the work done till now into the Example Repository which could be installed from the corresponding npm package
Cool @beingtmk! I just created the test-app using create-react-app⊠looking forward to playing around with it!
Take care, Mark
This is the final repository, where all my code will reside from now on,
This is based on a fork of create-react-app
there are two branches in this repository
- master - provides code for app with Minimal Configuration, which can be run using:
create-react-app test-app --scripts-version openmrs-react-scripts
- example - provides code for the example app with Basic Usage/Documentation, which can can run using:
create-react-app test-app --scripts-version openmrs-react-scripts-example
Hi @beingtmk,
I do not see the upstream for this repository. Can you fix it? Because itâs hard to compare the changes what you have done so far. And in future we also want to merge our fork with facebook repository to make our project up-to-date.
As we discussed in our previous meeting, can you design the homepage of the generated project to adhere with our default OpenMRS web UI template?
I have also modified the main readme file to make more clarity about the project. There are 3 more sections that I expect from you to fill it out.
PS: Please do not directly commit to the master branch of your repository. Make PRs and assign them to me.
I have added you as a collaborator, pls accept the invitation at
https://github.com/beingtmk/create-openmrs-app/invitations
and i have created a pr to fill in the missing peices in the Readme
@beingtmk https://github.com/openmrs/openmrs-owa-builtinreports/tree/master/app/js/components/common
These are the two final repositories for my submission
- Minimalistic Template: https://github.com/beingtmk/create-openmrs-app
- Example Template: https://github.com/beingtmk/create-openmrs-app-example
I have removed all the parts of the fork from facebook-cra which were unnecessary.
Now these repositories only contain the part that i have edited, which is of the package âreact-scriptsâ. This is the only part that is responsible for generating the final template.
Both of the above repositories are published to npm with travis ci integrated.
The way you generate a template is:
npx create-react-app test-app --scripts-version openmrs-react-scripts
so basically you are just using the create-react-app to generate the project, just that you are using the customized version of the âreact-scriptsâ, that is responsible for the final customization of the template once the project is generated by cra.
Hope this reduces maintainability to only those parts which we anyways need to maintain.
The UI of the Example Template has also been changed.
- Default OpenMRS UI
- Overview with props and other notes
- sample code
gif attached below
@beingtmk You have missed to submit your final evaluations on OpenMRS talk. Can you make it as soon as possible?
Final Demo Video,