Unstable builds of Reference Application 2.3 module

[mksrom (Romain Buisson)]

Hi all !

I am working with a fork of Reference Application module based on tag referenceapplication-2.3.

On the OpenMRS repo, the referenceapplication-2.3 tag doesn’t build. I think it almost never did.

To make it build, it is necessary to patch the pom.xml by adding dependency on ‘emrapi-api’ and ‘emrapi-api-1-11’ such as added by @raff on the master in commits a89b3f0 and 50f6d1d. (see post Suddenly can't build the Reference Application module)

This worked fine for the last few months.

But now the module doesn’t build anymore: test failures on OMOD: Ubuntu Pastebin without changing anything in the code.

---

That is a major problem for us to have this module suddenly stop building.

1/ Is the dependency on <distro.version>LATEST</distro.version> the reason of the problem ?

2/ Could we depend on <distro.version>2.3</distro.version> instead ?

Once a solution is found, and we are not depending on SNAPSHOT versions, I guess we could do as @darius suggests:

@darius

The OpenMRS community does not maintain multiple branches of any modules, only of openmrs-core.

if you wanted to do the work of creating this branch and tag and doing the release yourselves, I guess it would be fine for you to push those to the github and maven repositories, with some appropriate tag names

just to provide people with a working source code of this Reference Application module 2.3

OR… are we close to releasing 2.4 ? (so then skip 2.3)

[darius (Darius Jazayeri)]

Hi @mksrom,

I don’t have a good answer here; this is the same issue that @mogoodrich has brought up recently (though I can’t find the thread).

Basically, we started taking an unsafe shortcut a few years ago, by having a bunch of modules all share their dependency versions by importing the distro pom, but it seemed to not cause any real-world problems for years, though recently more issues have come up.

So, yes, the dependency on distro.version=LATEST is the problem, because it will try to build against always-incrementing versions of other modules. If setting it to 2.3 solves the problem, then go ahead and do that.

[mogoodrich (Mark Goodrich)]

@darius

just for reference, I believe this is the thread you were referring to?

Maintaining SNAPSHOT Maven dependencies

I ran into an issue with our dependency management within the ref app yesterday that unfortunately has no “easy” fix that is also “correct” that I know of. It’s not a blocker for our development right now and we have workarounds, but I wanted to share it just in case others run into the same issue: We know we have a circular dependency issue within the reference app: in order to make it easier to control/update what versions of modules go into a particular refapp release, most of the modules …

[mksrom (Romain Buisson)]

OK. Well, I tried to set the distro.version to 2.3 and it doesn’t solve the problem. After reading @mogoodrich thread you points me to, I understand now why.

Thanks. I’ll follow up there.