TRUNK-4954 obs and its encounter point to different persons

Development
1

I am currently working on[ this issue on https://issues.openmrs.org/browse/TRUNK-4954?filter=-1

I have added validation in obsValidator.java to accommodate few test cases in obsServiceTest.java Feel free give ideas to improve work on this issue.

Here is my pull request

Thanks

2

Did you take a look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips

3

@dkayiwa Yes I modified my PR. Feel free to review on https://github.com/openmrs/openmrs-core/pull/2541.

4

@dkayiwa The travis build fails in saveObs_shouldCascadeUpdateToNewChildObsGroups in ObsServiceTest.java. Feel free to help me to proceed from here.

5

@raff Could you please help me to correct the travis build in #PR- 2541

6

@madushan, you need to fix tests. They do not pass the validation you introduced. See e.g. https://github.com/openmrs/openmrs-core/blob/master/api/src/test/java/org/openmrs/api/ObsServiceTest.java#L1561 , which should be fixed to groupMember.setPerson(origParentObs.getPerson())

7

@raff The build fails due to the test method written before my modification in ObsValidator.java. Shall I modify the failing methods.

8

Yes, you need to fix the 4 failing tests, even though they were written long ago.

9

@raff Thanks. In the first failing test it shows following error. “saveObs_shouldCascadeUpdateToNewChildObsGroups(org.openmrs.api.ObsServiceTest) Time elapsed: 0.174 sec <<< ERROR! org.openmrs.api.ValidationException: ‘Obs #2’ failed to validate with reason: person: person objects of the obs and the encounter do not match” I find it hard to understand why the exception occurs?

10

https://github.com/openmrs/openmrs-core/blob/master/api/src/test/java/org/openmrs/api/ObsServiceTest.java#L1561 sets the person to new Patient(2) which is probably different from what is set on an encounter for that obs. See my previous reply on how to fix it.

11

@raff Thanks .I will follow your steps.

12

@raff I modified the code with your line. But it still caused the same exception. Digging into the matter showed me that an encounter with a different patient is auto assigned to the origParentObs which causes the exception. Here are the details.

in the test method

origParentObs id =2, origParentObs encounter = null, origParentObs person = Patient#2

in the new validation in ObsValidator.java

origParentObs id =9, origParentObs encounter = Encounter: [3 2008-08-01 00:00:00.0 Emergency Unknown Location 7 Basic Form num Obs: [Obs #7] num Orders: 3 ], origParentObs person = Person(personId=9)

13

@jwnasambu @dkayiwa Could you please tell me why the above scenario happens ?

14

@f4ww4z Could you please tell me why the above scenario happens ?

15

@suthagar23 @navareth Could you please help me to understand why this happens.