Tracking Progress of the Condition List Phase GSOC Project

My preference would be to eliminate the plus and minus buttons, since you have another easy way to activate or inactivate.

I would also prefer to make the condition name unchangeable in the edit form. If the condition was entered in error you can delete it (with the warnings above) and if your thoughts about the condition have changed, you can inactivate it and add a new one. In practice, it will be a fairly rare event that someone actually wants to do that.

1 Like

Thank you @jteich , I will make the condition name unchangeable in the edit form. I would like to take a vote on elimination of plus and minus button. @dkayiwa and @ball what’s your opinion on this?

PR on confirmation before deleting a condition -

2 Likes

Edit Conditions PR after making the condition name unchangeable

3 Likes

Thanks @haripriya on the above. Any updates on this , could we have all work done by this june??

  • Upgraded font awesome to latest version, to support a wider set of icons eg: awareness ribbon etc (In reference app)
  • Fixed the error while saving conditions:
  • Limit values of condition list based on its global properties
  • Add condition UI enhancement:
  • Cosmetic tweaks for Manage conditions
  • Added checks for onset date to ConditionValidator in core
  • Upgraded Fontawesome to latest 5.9.0 in UI commons
  • Fixed hover messsge for ‘x’ icon in manage conditions
  • Spent a good amount of time fixing my previous PR’s

  • Working on translations into other languages like french

  • Made suggestions regarding change of icons for coreapps (idea not yet approved) : talk link

  • Exploring cohortbuilder-owa to add functionality for condition list. Being new to owa its taking more time to figure out how things are working. : talk link

2 Likes

great @haripriya , thanks for the awesome work

1 Like

Thank you @mozzy

2 Likes

well done here

1 Like

Thank you @herbert24

2 Likes

we seem to have a little time remaining to the completion of the GSOC projects, can we get the update on the progress of this feature. could we be able to have it into ref app?? thanks cc @haripriya @dkayiwa @ball @c.antwi

@mozzy All the objectives under Condition List project have been completed.

These 2 features are to be merged:

  1. https://github.com/openmrs/openmrs-owa-cohortbuilder/pull/182
  2. https://github.com/openmrs/openmrs-module-coreapps/pull/192

I’m currently working on the changes being suggested on these PR’s and the documentation. Also trying to fix a bug reported by @ball.
Thank you :slight_smile:

2 Likes

thats sounds cool to hear @haripriya

1 Like

I’m getting error while adding condition on https://qa-refapp.openmrs.org/openmrs/ . To verify I cloned changes from https://github.com/openmrs/openmrs-module-coreapps , https://github.com/openmrs/openmrs-module-emrapi compiled and ran them on both standalone and snapshot versions, yet I’m not able to reproduce this error. I also tried running these changes on Ubuntu, yet I wasn’t able to generate this error and conditions were being saved successfully . Any help is appreciated. Thank you.

cc: @dkayiwa , @ball, @mozzy

i dont think that server is updated with the latest changes in core apps and emr-api modules. cc @dkayiwa @cintiadr

1 Like

@mozzy did you see this: https://github.com/openmrs/openmrs-distro-referenceapplication/blob/master/pom.xml#L41 and this? https://github.com/openmrs/openmrs-distro-referenceapplication/blob/master/pom.xml#L57

Thanks @dkayiwa. is that server continuously updated with any commit that gets merged ?? what am asking is , after merging any single commit at any time , is there auto continous rebulding of the modules??

Just want to confirm that, that server has been updated with @haripriya’s changes

It is rebuilt on every commit.

1 Like

ok , i get then. thanks

@dkayiwa I’m not able to reproduce the error when I test the latest changes on my local system. What could be the reason?