@bistenes Do you have any estimation Or design plan for this rewrite. I could also help something, i have skills on reactjs and redux, but not an expert. I also tested master branch and not seen like issue fixed. 1.1 is working version for drug order. 1.2 is not working.
Thanks Prapa
Thanks @bistenes.
@prapakaran are you sure you are using the latest master? I was able to successfully order a drug using it.
@mogoodrich I am using core 2.10 and order entry-1.2. You could refer the screenshots for the same. Let me also try to take some logs and put it here. Unable enter units which is not populating anything.
Ah, okay, weâve put in a couple fixes since the 1.2 release that we hope fixes that. Do you have the ability to test off master?
@mogoodrich The last build i took from master and tried with core 2.10 backend. The dropdown like Units are not populating which is working order entry-1.1.
@prapakaran I just released a Order Entry 1.2.1 with the fixes that @bistenes recently added. Can you see if that works for you? Thanks!
@mogoodrich @bistenes @ruhanga I tested 1.2.1. The edit and delete buttons are not working. I remember edit and delete options works for lab orders on version 1.1.0. I raised this defect for just adding edit/ delete button for drug orders.
@mogoodrich @bistenes Is there any option for fixing this issues. I am sure summer coding gives some opportunity to fix these type of issues.
Sorry, can you clarify what is working and not working at this point?
Are you saying that the edit and delete buttons appear now for drug orders in 1.2.1, but not for lab orders?
Take care, Mark
I checked out 1.1.0 (and cherry-picked 55d0b37 onto it, otherwise it wouldnât build). It appears that at that point one couldnât even add a new drug order.
@prapakaran Did creating drug orders work in 1.1.0?
Did edit and delete buttons for drug orders work in 1.1.0?
hello @prapakaran, my return button is throwing the same error as mention earlier with the latest order entry 1.2.1 @bistenes is this one of the things you intended to fix
@bistenes Please find my comments for both version.
1.1.0 - For lab order, delete button is working. For Drug order, edit/delete button are not working. I am able to add new drug order using core 2.10 version. 1.2.1- For lab order, delete button is not working. For drug order, edit/delete button are not working.
@spkabugo1 Can you please try the backend build. 2.10< it was fixed recently and not available on 2.10. Please find latest openmrs core build and use it. It is working. @ruhanga May i know when will be the next core version-2.11 get released.
Thanks @prapakaran. About the above, here is the link to the latest ref app builds at the moment; https://ci.openmrs.org/browse/REFAPP-OMODDISTRO-10046/artifact
The time line for the next Reference Application 2.11 is still being ascertained. You can followup on this on the technical roadmap here.
cc: @jennifer
@prapakaran I have just tried out the reference application version 2.11.0-SNAPSHOT, but still I get an HTTP Status 404 â Not Found error when you click on the Return button?
I am using orderentryui-1.2.0-SNAPSHOT and the latest release of the orderentry owa.
Thanks @prapakaran⊠I think Iâm seeing something close to what you are seeing, can you confirm if this is correct:
Obviously, we should fix the issue where the links donât work, but until we get to that we should at least change it back so that the links donât appear for Editing/Deleting drug orders.
For Lab Orders, deleting a lab order is working for me in 1.1.0 and 1.2.1. However, there is an exception⊠if you try to cancel a Drug Order and it fails, it breaks the entire page and you canât cancel a Lab Order until you reload the page.
I will prioritize removing the Edit/Cancel buttons for Drug Orders until we get that working, because it has definitely led to confusion!
Take care, Mark
Thanks @mogoodrich, @bistenes
@spkabugo1 thanks for testing. Could you please confirm this once more. Possibly try the latest snapshot artifacts built by bamboo ci here: Reference Application - Distribution 2.x 10053: Artifacts - OpenMRS Bamboo. Otherwise this was resolved recently by RA-1759.
@mogoodrich I am also in the same page. I raised the defect for adding drug order(edit/delete) and lab order(delete or cancel option). Is it possible to fix this issue? I am sure the feature need to be add to fulfill the requirements.
Hey @prapakaran. Weâre probably not going to be fixing that very soon, because itâs actually because of much deeper problems, as I mentioned earlier. A complete refactor of the data layer is needed.
Something that would be incredibly helpful that I think you or @ruhanga could do would be to create a suite of Cypress tests for the OE OWA.
Right now, the unit tests that exist are tightly coupled to the Redux store. This is a big problem because it means that we canât change the data layer without breaking the tests. We need integration tests: tests that mock only the network requests and test only the user interface.
We donât need many of these tests. They just need to check that the important pieces of functionality work.
Do you think either of you could make the time to do that? If so, I would be happy to provide guidance, clear specifications, and code review.
