Order entry UI Return button not working

prapakaran · May 15, 2020, 1:00am

@ruhanga It looks return button is not working and also no option for edit/delete drug order.

ruhanga · May 15, 2020, 7:16am

Thanks for reporting this @prapakaran. Could you create an OEUI card for this? If you can wire a PR to help resolve this, feel free to do so. That’d be helpful already.

prapakaran · May 17, 2020, 5:00am

@ruhanga I raised jira card and also checking the code. May i know where to pass returnURL. It was missing.

github.com

openmrs/openmrs-owa-orderentry/blob/master/app/js/components/orderEntry/OrderEntryPage.jsx

import React, { PureComponent } from 'react';
import { connect } from 'react-redux';
import moment from 'moment';
import PropTypes from 'prop-types';
import { bindActionCreators } from 'redux';
import { FormattedMessage, injectIntl } from 'react-intl';
import { PatientHeader } from '@openmrs/react-components';
import RenderOrderType from './RenderOrderType';
import SelectOrderType from './SelectOrderType';
import Draft from '../Draft';
import fetchPatientCareSetting from '../../actions/careSetting';
import { getSettingEncounterType } from '../../actions/settingEncounterType';
import { getSettingEncounterRole } from '../../actions/settingEncounterRole';
import { getLabOrderables } from '../../actions/labOrders/settingLabOrderableAction';
import getDateFormat from '../../actions/dateFormat';
import activeOrderAction from '../../actions/activeOrderAction';
import { fetchPatientRecord, fetchPatientNote } from '../../actions/patient';
import { setSelectedOrder } from '../../actions/orderAction';
import { successToast, errorToast } from '../../utils/toast';
import { loadGlobalProperties, APP_GLOBAL_PROPERTIES } from "../../utils/globalProperty";

This file has been truncated. show original

Line number 34

ruhanga · May 18, 2020, 6:32am

Thanks @prapakaran. I’ve created RA-1759 that will hopefully fix this. Could you also point me to the Jira card you created?

prapakaran · May 18, 2020, 2:25pm

Thanks for fixing this. Please find the card details. https://issues.openmrs.org/browse/OEUI-308?filter=-2 One more thing, edit/delete button are not available for drug order entry. I will also look at this code.

prapakaran · May 19, 2020, 10:18pm

@ruhanga is anyone looking edit/delete button on drug orders.

ruhanga · May 20, 2020, 10:57am

@prapakaran, this may have been intended to prohibit editing an active drug order. Editing the prescription is possible only when the it is still in its draft state. This means editing an active drug order requires that it is deactivated/discontinued in favour of a new prescription.

@mogoodrich could this be consistent with the original intension?

cc: @darius, @mseaton, @mksd, @mksrom

mogoodrich · May 20, 2020, 1:47pm

Yes I believe this is intentional because drug orders are immutable… I would think we’d want a way to cancel an order though… i haven’t looked at the UI in a while, so this may not currently be possible?

prapakaran · May 20, 2020, 10:46pm

@ruhanga @mogoodrich Sometimes the medicine allergy/dosage may not work for a patient then the doctor prescribes a new drug and discontinue the old one. I am guessing we may required button to discontinue the drug like lab orders. Even i have gone through the scenario in my experience.

mogoodrich · May 20, 2020, 11:40pm

Yes, I agree there should be functionality to discontinue/cancel an order…

prapakaran · May 21, 2020, 10:56pm

@ruhanga @mogoodrich Is anyone help on this to fix the issue.

ruhanga · May 22, 2020, 12:45pm

@prapakaran, I’ve just had a quick look at the code base and it looks something is breaking on this peace of code. Could you investigate further on this?

@cioan, @bistenes you may want to offer some guidance on this.

mogoodrich · May 22, 2020, 1:18pm

Thanks @ruhanga I will try to take some time to refresh myself in greater detail on how it’s supposed to work, but I might not get to it immediately.

Take care, Mark

mogoodrich · May 25, 2020, 8:54pm

Yes @ruhanga @prapakaran this looks like (as opposed to an unimplemented feature). My guess is that there’s a bug here, where’s trying to match on type = drugorder:

github.com

openmrs/openmrs-owa-orderentry/blob/master/app/js/utils/helpers.js#L18


  path,
) => data.filter((item) => {
  if (item[path]) {
    return (dateToInt(from) <= dateToInt(item[path])) && (dateToInt(to) >= dateToInt(item[path]));
  }
  return true;
});


// encapsulates our logic as to whether or not a order is cancellable or editable
// in the future we will likely want to tweak these and/or make them more configurable
export const isCancellable = order => order.type === 'drugorder' ||
  (order && order.orderType && order.orderType.name === 'Test Order' && (!order.fulfillerStatus || !['IN_PROGRESS', 'COMPLETED'].includes(order.fulfillerStatus)));


export const isEditable = order => order.type === 'drugorder';


export const getConceptShortName = (concept, locale) => {
  let conceptName;
  const localeShort = locale ? (locale.split('_'))[0] : "en";


  if (concept) {
    if (concept.names && concept.names.length > 0) {

ruhanga · May 26, 2020, 7:56am

Thanks @mogoodrich. Also it looks like custom representations are not decorated with the subclass’ type here. So that the above seems to fail for drug orders given that the orders are fetched with a custom representation.

prapakaran · June 6, 2020, 3:04pm

@ruhanga @mogoodrich I tested return url and it is working as expected. I also tried order-entry-1.2.0 release. Drop downs are not populating for units and unable to save drug details. Edit/Delete button is missing. I used the below link for openmrscore https://ci.openmrs.org/browse/REFAPP-OMODDISTRO-9958/artifact Please refer the drug entry screenshot. @saravanan

Server log:

ruhanga · June 7, 2020, 5:22pm

Thanks for testing this @prapakaran . A couple of fixes are being pushed to the project on github so that reporting these bugs is useful already. Could you use pastebin.com for the error logs? Thanks.

cc: @bistenes, @mogoodrich

mogoodrich · June 10, 2020, 12:01am

Cool thanks @ruhanga! (sorry looks like I missed this earlier…). Do we have a ticket to fix (or maybe it’s already fixed, I haven’t been following to closely).

prapakaran · June 11, 2020, 1:47am

@mogoodrich the front-end defects like edit and delete for drugs, additional return button (refer the screenshots) are still there.

@ruhanga For backend service call, please refer the screenshot left side and do you want share new build for checking service call.

ruhanga · June 11, 2020, 6:32am

Thanks all, sorry I could not reach you on time. @mogoodrich, we have a ticket for this, OEUI-308.

@prapakaran, the latest build of the orderentry owa can be found on bintray here https://bintray.com/openmrs/owa/openmrs-owa-orderentry.