Core Apps patient page look and feel different on desktop browsers

Tags: #<Tag:0x00007fe2e6caeee8> #<Tag:0x00007fe2e6caee20> #<Tag:0x00007fe2e6caed58>

Hi all,

There is a difference in the way that coreapps display some views as of the latest SNAPSHOT. An example is the patient page that displays as below in a full-sized browser window. It is possible that this could be breaking my end by something missing.

The demo displays this page differently.

@ssmusoke, @ayesh, could I be missing a point on the work that was completed and merged on the related project ticket RA-1592. This works probably as intended on mobile devices but seems backwards incompatible on desktop browsers. I am using Chrome(Version 76.0.3809.132) and firefox(quantum 68.0.1).

cc: @mksd

1 Like

Hi @ruhanga

This can be version mismatch can u send me the server link with a sample user so I can check on it and get an idea about the issue

I’ve reproduced this on a local instance. You may reproduce this by building the coreapps module cloned from github and installed on a fresh Ref App instance. We could probably jump on a call so I demonstrate this here https://uberconference.com/openmrs

1 Like

@ruhanga I think this is all visible on QA Ref App: https://qa-refapp.openmrs.org

@ayesh there are other UI issues that are visible. A fairly major one is that it is not possible anymore to start a visit since everything, including the confirmation popup, become part of the greylined background:

Strangely here the dashboard looks normal otherwise, that’s on Chrome 76.0.3809.100.

Cc @ssmusoke

2 Likes

Hi @mksd

Yes this issue is clearly there am addressing it.

@ruhanga sorry am stuck at meetings.Can u let me know a good time to connect.

Thanks @mksd, @ayesh, could I be missing a dependency on some styling that probably ships with some module.

1 Like

@ayesh there are clearly a couple of changes that are either breaking the UI or that are subject to debate. In the latter category, see how the buttons are of different sizes on the apps screen:

1 Like

@ruhanga You are probably not missing anything, migrating to bootstrap is an involved process, hence the drive to merge and get it tested out quickly to identify the different elements we may have missed

1 Like

Hi @mksd

I actually noticed that.And the problem is fixed as well.

As I opened a new talk thread to ask about this issue I mentioned below in that thread

When it comes to the reference application module after it’s build it’s creating a folder call sass-external.In here it refers to uicommons module sass files. Like below image !

Screenshot%20from%202019-08-30%2017-49-22

My question is it’s always referring to the ui commons without latest changes in github means to a former build or a released version.How can we change it to point to the new changes in the github.

It’s because when it comes to :- “https://qa-refapp.openmrs.org” it’s referring to latest changes in github so things are not working well without latest commons module changes. :slightly_smiling_face:

I am still seeking the solution for this problem.

@ssmusoke so you’re expecting some real-time QA from the community? I guess that’s the only way to really get things moving, but it’s a little… brutal maybe? :wink:

Is there a place where we can gather this feedback?

1 Like

@ayesh you could force a rebuild of UI Commons from the CI.

1 Like

Unfortunately we had to use that approach, so that @ayesh can complete his GSoc project that has been over 20 months in the making.

Just keep sharing it here, since he is currently working across 6-8 different modules, which is the tough part… I feel for him, but he has not broken down yet

1 Like

I am forcing a build of ui commons then reference application - thanks @mksd for the advice and support much appreciated

2 Likes

@ayesh Can u try changing the UI Commons version here https://github.com/openmrs/openmrs-module-referenceapplication/blob/d67085832334bd1e77c06b0ca5fecb116a17f1a1/pom.xml#L63 to the latest snapshot

1 Like

Hi @ssmusoke

Stephe I will try with the latest snapshot.

Hi @ssmusoke

I think not referring the latest snapshot was the issue thanks for pointing out :smiley: .Shall I send a PR with the fix for that.

Hi @mksd

I am looking at the issues one by one.And the below issue is actually because dev servers not pointing to the latest snapshots as @ssmusoke mentioned.

995d285afdc23f0bdbc2c5f2077c1168816095d8_2_690x248

Now it’s working as below

2 Likes

@ayesh can you make a PR to https://github.com/openmrs/openmrs-module-referenceapplication/blob/master/pom.xml to update to the latest snapshots

1 Like

Hi @ssmusoke

Hi stephe alreaydy created.Here it is.

Hi @ayesh some of the key issues are still visible on QA Ref App:

  • It is not possible to start a visit from the clinical dashboard.
  • The app buttons are still of different dimensions.

While the latter is minor, it still shows that upgrading to the latest UI Commons does not make it go away.