Configuring Multiple Report Apps

arjun · March 27, 2018, 7:11am

Hi,

There is a wiki page that mentions that there is an ability to configure multiple reports apps in Bahmni : https://bahmni.atlassian.net/wiki/spaces/BAH/pages/59899908/Configure+Multiple+Report+Apps

However setting it up as per the steps mentioned on the wiki doesn’t work. With a quick review of the code, i see some code in Bahmni apps reports to receive appName but the code to pass the appName seems to be missing.

Has anyone seen this working ever? Am i missing something?

shruthipitta · March 27, 2018, 11:12am

Hi Arjun ,

Can you point us to the code in github where you are suspecting the issue is?

arjun · March 27, 2018, 11:42am

Hi Shruthi,

Well, with disclaimer that my knowledge of the codebase is basic, i didn’t find where the appName is getting passed. when i setup a new app/extension with the appName parameter in configuration, it still didn’t get passed on to this line when checking in debug (and of course it wasn’t showing the intended new report app)

github.com

Bahmni/openmrs-module-bahmniapps/blob/master/ui/app/reports/initialization.js#L6


'use strict';


angular.module('bahmni.reports').factory('initialization',
['authenticator', 'appService', 'spinner', 'configurations',
    function (authenticator, appService, spinner, configurations) {
        return function (appName) {
            var loadConfigPromise = function () {
                return configurations.load([]);
            };
            var initApp = function () {
                return appService.initApp(appName || 'reports', {'app': true, 'extension': true }, null, ["reports"]);
            };


            return spinner.forPromise(authenticator.authenticateUser()
                .then(initApp)
                .then(loadConfigPromise));

Rather, if i may suggest, this is a 5 min thing to try out , so if you could try it out and see if it works for you that would be faster for us to understand where the problem is.

vinay · March 28, 2018, 4:54am

The problem is not just openmrs-module-bahmniapps. bahmni-reports does not support handling multiple file config urls. There is only one reports.config.url that can be configured in bahmni-reports. This looks like a feature that was planned but partially reverted. Might as well delete that wiki page (I can’t find my login button, so will need help here).

The original problem we set out to solve was that we had a long list of reports and needed a way to segregate them. There are 2 ways I can think of to fix this problem

Add report groups on the main reporting app
Add ability to create multiple reporting apps

arjun · April 3, 2018, 12:47pm

Hi, I caught up with @sdeepak and learnt that this is not yet done at the implementations though the requirement was/is there. So i believe the feature got left in half-done state.

Would it make sense to complete this feature? I see this as a valid requirement with no known workarounds.

Would it make sense to have a JIRA card or trello card on feature board for this?

@darius @mksd @angshuonline

mksd · April 3, 2018, 4:36pm

Just to make sure, this is about segregating reports under a new app, but fundamentally those are still just Bahmni reports as usual?

arjun · April 3, 2018, 5:21pm

Yes, that’s correct.

darius · April 3, 2018, 5:38pm

There is a real use case here, which we should definitely address.

To me the first option of having multiple groups/categories in the main reporting app makes more sense.

See for example this thread requesting that exact feature (which unfortunately got dropped over the new year):

What’s the argument for doing the multiple apps approach?

arjun · April 3, 2018, 6:05pm

I think its the same endTB requirement for which this feature was started to build.

may be @sdeepak or @prabhuawasthi will be able to throw light on why a multiple apps approach was taken to solve this problem. my guess was that it could have been lower effort to do it that way. and also leverage the privilege feature which already exists for apps. say, one app is EMR reports focussed and other pharmacy/ERP focussed. It would be of interest to restrict usage of particular group of reports to specific users. Of course, the privilege feature could be added to tabs as well.

arjun · April 11, 2018, 10:55am

Any suggestions on how to move this forward?

@mksd @darius

darius · April 11, 2018, 4:26pm

@arjun can you do a quick lo-fi mockup of how you think this should work, as well as a quick sketch of how you think the config would look?

Personally I prefer having groups/tabs/sets, versus multiple apps, but it’s up to you which you think works better based on your understanding of the use case. In the long run we could actually support both of these…

(Broadly speaking, we have a shortage of JIRA tickets that are small/medium in size, and clearly ready for work. To the extent that you can help us get tickets into this state, then the dev team can pick from among these.)

arjun · April 16, 2018, 10:25am

Hi,

I have created this story card #508 considering groups within a single app as the commonly agreed approach.

Whoever concerned, please review and add/edit/comment. Also, i think we should delete the documentation and code for configuring multiple apps.

cc: @darius @mksd @angshuonline @vinay