We need your input about what bug fixes you would like to see in Platform 2.1.2

On the design forum this Monday we reached a consensus that in order to keep our commitment of having a platform release every year, we will be releasing platform 2.1.2 rather than 2.2 which will technically be core 2.1.2 (to be released) plus a couple of key bug fixes along with the upgraded modules, for more details on how we came to this decision please see Burke’s talk post here.

We would like to give you the opportunity to participate in picking the key bug fixes you would like to see go into the 2.1.2 release, here is a quick link to the list of tickets that you can pick from. We can use the vote feature in jira on each ticket to the right under the People section for voting purposes, a certain count of the top voted tickets will be picked.


Thanks @wyclif. I just added the release/fix version ‘Platform 2.1.2’ in JIRA.

First ticket for us with that fix version:

TRUNK-5231: Lucene support for partial patient identifier searches

Cc @ekirapa

Thank you so much @mksd. Please members i believe we do not have much time left from now to end of December when this release ‘Platform 2.1.2’ to be done. May i see more input on the tickets you would like to see in the release?

Thanks @mksd! I think the voting approach works better and then we would set the fix version only for the selected tickets.

Hello @wyclif and all Devs, we need to set the date for the release and also agree on the tickets that shall be included in Platform 2.1.2

@wyclif why don’t we just include all the bug fixes which were done but not back ported?

Hello @dkayiwa could we agree on the release date so that we work towards hitting the deadline? Thanks.

1 Like

Hello @wyclif, @dkayiwa, @burke, @raff, @darius, @jtatia, @Bharat Akkinepalli and all Devs, we still have this ticket (TRUNK-4956 ObsGroup is set as an immutable property on Obs that cannot be changed, but we are marking it null in obs.removeObsGroup ) which is a bug and ready for work but hasn’t been assigned to anyone yet. Please could we get someone to work on it so we hit the deadline? Thank you very much.

It’s time consuming to cherry pick all the big fixes, I feel like we have little time.

@irenyak1 any incomplete ticket in core should be automatically bumped to the next version and that applies to TRUNK-4956

@wyclif are they that many?

@wyclif ok then

@dkayiwa, @wyclif not really, it’s only one ticket TRUNK-4956 whose work seems to be still much because its not assigned to anyone yet. The rest of the tickets two are closed (TRUNK-5239 and TRUNK-5123) while three (TRUNK-5231, IDGEN-33 and IDGEN-42) are in progress, hoping they will be completed soonest.

Yes, about 50

@mksd TRUNK-5231 is not a bug fix.

@irenyak1 TRUNK-4956 has to be bumped because it’s not done yet.

@wyclif, i have back ported all the tickets we agreed upon as per the summary below:

https://issues.openmrs.org/browse/TRUNK-5182 Extract private methods in ConceptServiceImpl.saveMethod - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5167 PersonEditor does not throw if Person not found - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5117 Refactor PersonServiceImpl.getPersonAttributeTypes - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5111 Replace use of deprecated isVoided - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5106 Replace use of deprecated isPreferred - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5104 Replace use of Person.isPersonVoided - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5102 Remove leftover suppresswarnings - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5098 Add missing override annotations - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5097 Unnecessary fully qualified name - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5096 Remove MemoryLeakUtil.shutdownKeepAliveTimer - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5063 Extract private method in ConceptServiceImpl.saveConcept - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5062 Extract private method in EncounterServiceImpl.saveEncounter - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5057 Extract private methods in OrderServiceImpl.saveOrder - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5055 Improve PersonServiceImpl.getPersonAttributeTypes - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5054 Extract private methods in PersonServiceImpl.savePerson - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5053 Refactor ProgramWorkflowServiceImpl.saveProgram - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5049 Refactor VisitServiceImpl.stopVisits - (Not Necessary) https://issues.openmrs.org/browse/TRUNK-5047 Replace duplication in UserServiceImpl by StringUtils - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5046 Remove commented out code - (Not Necessary) https://issues.openmrs.org/browse/TRUNK-5045 Extract private methods in PatientServiceImpl.savePatient - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5043 Remove unused temp variables - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5040 Inefficient use of map - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5034 Merge collapsable if statements - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5032 Remove unused private fields - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-4924 BaseCustomizableData setAttribute fail on minOccurs and maxOccurs - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5159 Remove isAuthenticated check in PropertyEditors - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5162 Few PropertyEditor getAsText return null if value is null - (Not Necessary)

https://issues.openmrs.org/browse/TRUNK-5165 ConceptMapTypeEditor does not get object via uuid - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5166 ConceptReferenceTermEditor should get object via uuid - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5157 ProgramWorkflowEditor tries to get workflow by uuid twice - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5154 ProgramWorkflowStateEditor tries to get state by uuid twice - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5133 Exclude activation.jar file from core - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5114 Using different logging implementations instead of facade - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5031 UpgradeUtil may not close a stream - (Back ported)

https://issues.openmrs.org/browse/TRUNK-4868 Setting a deathdate does not call setDead() - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5112 Patient Merge encounter Obs group are not assigned properly - (Back ported)

https://issues.openmrs.org/browse/TRUNK-5156 Add ProgramWorkflowService.getWorkflow(Integer) - (Back ported because of TRUNK-5157) - New Feature

https://issues.openmrs.org/browse/TRUNK-5155 Add ProgramWorkflowService.getState(Integer) - (Back ported because of TRUNK-5157) - New Feature

The above were a result of this JIRA query: project = TRUNK and fixVersion = “Core 2.2.0” and fixVersion not in (“Core 2.1.1”, “Core 2.1.0”) and status = closed and type = Bug

I also tried to search for tickets without a fix version using the fixVersion is EMPTY option and the majority of them were closed as duplicates, won’t fix, cannot reproduce, information provided, cancelled, etc. Nothing worth back porting.

I also did take a look at those tickets whose type is not in (New Feature, Bug) and found around 28 of them, with type Task, but still none was worth back porting.

So this means we are ready to proceed with the next release steps, unless any one feels i have left out something.

NB “Not Necessary” means not back ported.

Thank you so much @dkayiwa.

@irenyak1 Are you now clear on the next steps?

Reading through this wiki page https://wiki.openmrs.org/display/docs/OpenMRS+Platform+Release+Process to get the next step clear.

@dkayiwa you posted 38 tickets that are bug fixes , however in my search if am to include New Features and Tasks i get 66 tickets some of which have both fixversion core 2.2 and Platform 2.1.2 though some have only fixversion core 2.2. All of the 66 tickets are closed.

Does it mean those are the tickets that shall be included in the Platform2.1.2 release?

There’s also one ticket in progress ( TRUNK-5231) assigned to @ekirapa with fixversion core 2.2 and Platform 2.1.2.

So does that mean Platform 2.1.2 will have the 66 tickets plus the pending one if completed in time? or could there be more tickets I have left out?

The above is not directed to @dkayiwa alone but to everyone here.

Thank you very much. Irene.

Hello @ekirapa, how far have you gone with ticket TRUNK-5231, do you think it will be completed in time to be included in the Platform 2.1.2 release or we forward it to the next version of the release?

Thank you very much.