Using OWASP LAPSE and ZAP for security analysis


As suggested by @mseaton at [1], I was going through the code to find the possible security holes and thought of using a tool.

I used the LAPSE tool [2] and generated a report for reporting module. Please find the report at [3].

I have marked some sinks in red for SQL injection and AFAIU, I think there is a vulnerability since they replacing the values in the PreparedStatement instead of using setValue method.

Before discussing these I think, it is better to have the report with us. I am scanning the openmrs-core as well and will give the report ASAP. Also I am manually going through the report issues to find out whether they are really needed to be fixed.

It is true that most of these are False positive,since it is doing static analysis But I think it will be a good step to prevent security vulnerabilities in our code, which indeed increase the quality of our product.

ZAP [4], is another penetration testing tool, which will find vulnerabilities dynamically. So using that we will be able to get more positive results. I hope to do that ASAP and provide the report ASAP.

AFAIK, both of these static and dynamic analysis should be done to get the best out of it.

As a newbie, I don’t know what has happened in the past. So please point, to the past work that openmrs has done regarding this. :slightly_smiling:

[1] [2] [3] [4]

Thanks & Regards, @ttcphilips

1 Like

@ttcphilips this is a great initiative! Please keep up the awesome contributions! :smile:

I updated the doc with the scan for reporting and htmlwidget modules.