Hi everyone,
I recently submitted my first PR to openmrs-core:
master ← siddhi2005-beep:improve-javadoc-patientidentifier
opened 06:25PM - 12 Mar 26 UTC
## Description of what I changed
Improved null-safety and readability in the … `PatientIdentifier.DefaultComparator`
class.
Previously the comparator accessed `pi1.getIdentifierType().getPatientIdentifierTypeId()`
and `pi2.getIdentifierType().getPatientIdentifierTypeId()` without ensuring
`identifierType` was non-null in all execution paths.
This change improves code robustness by ensuring null checks are handled
before accessing nested properties. This prevents potential NullPointerExceptions
during patient identifier comparisons.
Additionally, the change improves readability by keeping null-handling
logic consistent with existing OpenMRS utility comparison methods.
## Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-0
## Checklist: I completed these to help reviewers :)
- [x] My IDE is configured to follow the code style of this project.
- [x] I have added tests or confirmed existing behavior remains unchanged.
- [x] I ran `mvn clean package` before creating this pull request.
- [x] All new and existing tests passed.
- [x] My pull request is based on the latest changes of the master branch.
A contributor suggested that the PR be linked to a Jira ticket.
However, when I try to create an issue in the OpenMRS Jira instance, I get the error: “You are not authorized to perform this operation.”
It seems my account does not yet have permission to create Jira issues.
Could someone please help enable Jira issue creation access for my account?
OpenMRS ID: siddhi2005-beep.
Thank you!
jwnasambu
March 16, 2026, 11:37am
2
Kindly do you have access to jira/wiki? if not request for access by filling this quick form: OpenMRS HelpDesk