irenyak1
(Irene Nyakate)
December 13, 2017, 12:32pm
1
Hello @ryan97 @dkayiwa , @wyclif , @raff , I need your guidance on this issue, on this wiki page (https://issues.openmrs.org/projects/TRUNK/versions/22701 ) the issue is indicated to have been marked complete but have open pull requests . Is there still work being done on the issue?
Thank you.
dkayiwa
(Daniel Kayiwa)
December 13, 2017, 3:08pm
2
Can you share links to the open pull requests for that ticket?
irenyak1
(Irene Nyakate)
December 13, 2017, 8:12pm
3
@dkayiwa I don’t think it’s this one but just look at this wiki page https://github.com/openmrs/openmrs-core/pull/2213 . The challenge it’s the only ticket that shows some work is still being done on it. What could be the reason for the warning as per this wiki page https://issues.openmrs.org/projects/TRUNK/versions/22701
irenyak1
(Irene Nyakate)
December 13, 2017, 8:19pm
4
This link seems to show that there’s 1 open pull request on this Ticket https://issues.openmrs.org/browse/TRUNK-4868?filter=-1
dkayiwa
(Daniel Kayiwa)
December 13, 2017, 8:23pm
5
Can you give the link to the open pull request?
irenyak1
(Irene Nyakate)
December 13, 2017, 8:31pm
6
I can’t find the link to the open pull request but from the link I posted above, it indicates that there’s 1 open pull request on that ticket,
dkayiwa
(Daniel Kayiwa)
December 13, 2017, 8:42pm
7
I have looked at the link, but i do not yet understand what you mean by it shows there is one open pull request. Can you say exactly what it is, or give a screenshot of it?
irenyak1
(Irene Nyakate)
December 13, 2017, 8:52pm
8
I have taken the screen shot and circled the part of the open pull request I’m talking about,
dkayiwa
(Daniel Kayiwa)
December 13, 2017, 9:02pm
10
Click on that pull request link. Then follow it up to see if the pull request is actually still open.
irenyak1
(Irene Nyakate)
December 13, 2017, 9:09pm
11
When I click on it, it brings the 3rd snapshot.
irenyak1
(Irene Nyakate)
December 13, 2017, 9:15pm
12
If i follow it further this is where it leads me. And this indicates that the pull request was closed I think. Now if it was closed, my question is, Why does it still show that there’s an open pull request??
dkayiwa
(Daniel Kayiwa)
December 13, 2017, 9:18pm
13
Good question. It could be that JIRA has not yet refreshed, a bug in JIRA, or something else that i do not know yet.
irenyak1
(Irene Nyakate)
December 13, 2017, 9:22pm
14
How do I follow it up to see that this status changes, or is it beyond my scope? It is the only ticket pending completion.
dkayiwa
(Daniel Kayiwa)
December 13, 2017, 9:29pm
15
Is the ticket closed and pull request closed? If yes, that is all you need.