Support for MIME types - Core issue

tmarzeion · February 1, 2017, 12:32pm

Hey, I am currently working on RESTWS-641 issue, which is about supporting MIME types when posting complex obs. I faced problem where ContentType of my response was always "application/octet-stream". After investigating code I’ve realized that it is caused by BinaryDataHandler, which always sets ComplexData's mimeType to "application/octet-stream" value. Check out code below:

github.com

openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/obs/handler/BinaryDataHandler.java#L84


			// No other view supported
			// NOTE: if adding support for another view, don't forget to update supportedViews list above
			return null;
		}
		
		Assert.notNull(complexData, "Complex data must not be null");
		
		// Get the Mime Type and set it
		String mimeType = OpenmrsUtil.getFileMimeType(file);
		complexData.setMimeType(mimeType);
		
		obs.setComplexData(complexData);
		
		return obs;
	}
	
	/**
	 * @see org.openmrs.obs.ComplexObsHandler#getSupportedViews()
	 */
	@Override
	public String[] getSupportedViews() {

As a solution I would just pass file.getContentType() as setMimeType() argument instead of fixed String value. What do You think?

Tomek

dkayiwa · February 1, 2017, 12:48pm

Your proposal makes a lot of sense to me.

wyclif · February 1, 2017, 5:03pm

That seems to make sense, but I’d imagine that fixing it in core can be done in a separate ticket, my question is can’t we get the rest module working with mime types regardless of what you get back, with this ticket what we want is for one to be able to get back the complex data via rest

burke · February 1, 2017, 5:22pm

I assume you mean file.toURI().toURL().openConnection().getContentType(). This can return null, so you’d still need to have a default value if it’s null. Also, worth consideration:

¹Get the Mime Type from a File

tmarzeion · February 2, 2017, 7:25am

Thats the way I did it: mimeType = Files.probeContentType(file.toPath()); and then, to ensure there is default value when something goes wrong: mimeType = mimeType != null ? mimeType : "application/octet-stream";

PS. Here is PR with changes: https://github.com/openmrs/openmrs-core/pull/1982#partial-pull-merging

flobue · July 22, 2017, 3:02pm

This might be a stupid question so please bear with me, but apart from being somehow cleaner to assign the correct MIME type, how does it affect the front-end?

I mean the browser seems to know how to display the picture I uploaded even with the current way of handling.

dkayiwa · July 27, 2017, 6:30pm

@flobue how about other clients which may not be as intelligent as the browser?