mogoodrich
(Mark Goodrich)
July 22, 2020, 7:24pm
1
I noticed that in the PIH bamboo the REST Web Services module build starting failing yesterday with test failures.
I checked the OpenMRS pipeline and REST Web Services was green… but it hadn’t run in two weeks. I manually triggered it, and it’s red, see:
https://ci.openmrs.org/browse/RESTWS-RESTWS-878
The 2.4 omod module of REST web services is dependent on Core 2.4.0-SNAPSHOT, so it’s likely a change to Core broke the tests. I can’t identify the exact commit because our build only runs nightly, but the build last passed on 19 Jul 2020, 3:40:42 AM (Eastern Daylight Time) and first failed on 21 Jul 2020, 3:41:39 AM (EDT) (not sure why it didn’t run on July 20th), so it’s likely a commit during that time frame that caused the issue.
Also, I’m thinking we should be setting up REST Web Services to build whenever OpenMRS master is built?
@dkayiwa @ibacher @teleivo @sacull @fruether @burke
Take care,
Mark
1 Like
dkayiwa
(Daniel Kayiwa)
July 22, 2020, 9:25pm
2
Fixed it at https://github.com/openmrs/openmrs-module-webservices.rest/commit/bdf09930cc259fa4735a579006da5b6b5c99c49f and configured OpenMRS master to trigger the building of the REST Web Services module.
Thanks @mogoodrich for bringing this up!
8 Likes
mksd
(Dimitri R)
July 22, 2020, 9:28pm
3
Great stuff @dkayiwa , as always. Thanks.
3 Likes
mogoodrich
(Mark Goodrich)
July 22, 2020, 9:43pm
4
Agreed, thanks @dkayiwa !!
2 Likes
teleivo
(Ivo Ulrich)
July 24, 2020, 11:38am
5
The fix might have caused coverage to drop by almost 50%. See https://coveralls.io/builds/32230247
Could be that files needed by the library reporting the coverage to coveralls are overwritten by the execution of the integration tests.
1 Like
teleivo
(Ivo Ulrich)
July 24, 2020, 3:14pm
6
there is a clean
before we run the integration tests. that supports my hunch that we remove info needed for coverage. I removed the clean to see if that fixes it https://github.com/openmrs/openmrs-core/commit/02eab6aa5a6cc74b377839eeafb090e4fa0ea6ae
1 Like
teleivo
(Ivo Ulrich)
July 24, 2020, 5:07pm
7
removing the clean before running the integration tests did put coverage back to the level we had before https://coveralls.io/builds/32305514
1 Like
dkayiwa
(Daniel Kayiwa)
July 25, 2020, 6:12pm
8
Thanks @teleivo for following this up!