REST module Concept Mapping error

Software Add-on Modules
, ,
1

Hi all,

With reference to this resolved issue https://issues.openmrs.org/browse/RESTWS-468 : I am trying to use Concept mappings instead of uuids for posting data to OpenMRS via REST.

The post below works perfectly fine and submits data successfully

{"obs":[{"concept":"5088AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA","value":"37"},{"concept":"5087AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA","value":"55"}],"patient":"27ba4993-24a9-4db2-b2e7-2ec3b9a23744","location":"pakistan","provider":"aeb5ecd0-cebe-11e4-9a12-040144de7001","encounterType":"patient_register","encounterDatetime":"2015-02-01"}

However, when I try to use Concept mappings as suggested in ticket the call fails

{"obs":[{"concept":"CIEL:5087","value":"55"},{"concept":"CIEL:5088","value":"37"}],"patient":"27ba4993-24a9-4db2-b2e7-2ec3b9a23744","location":"pakistan","provider":"aeb5ecd0-cebe-11e4-9a12-040144de7001","encounterType":"patient_register","encounterDatetime":"2015-02-01"}

The error with complete stacktrace in tomcat catalina.out is here pastie.org/10106883

The version of module is Rest Web Services - 2.9.39bd19.

Am I making any mistake in sending the post? Do I need to use any other version?

Thanks, Maimoona IHS (Interactive Health Solutions)

( @darius @ahabib )

2

What version of OpenMRS do you use? Referencing concepts by mappings is only supported for 1.9+.

3

@raff - its Version: 1.9.7 Build 60bd9b

4

The error in logs is NPE, which may imply that no concept with the CIEL:5087 or CIEL:5088 same-as mapping was found. Did you verify that concepts have those mappings?

5

@raff . Yes concepts with mappings exists. Also I am using the same request with just changed concept field value during data post. Thats how both concepts look like

6

Apparently get by mapping only works when fetching a concept but i see there is a bug in ObsResource where they only looking up a concept by uuid so the concept mapping fails, you can create a ticket to get it fixed so that it supports concept mappings too. We should probably get rid of the method with @PropertySetter annotation in ObsResource1_8.java to get it to work

7

Maimoona,

Is there any chance that you can write a failing unit test that demonstrates this issue? I can probably help fix it.

8

Wyclif is right, ObsResource1_8.setConcept must be modified to replicate the behavior of ConceptResource1_9.getByUniqueId and possibly other resources using concepts.

To avoid code duplication we should probably move ConceptResource1_9.getByUniqueId to the Concept Service.

9

Hi @darius, I have reported the issue here https://issues.openmrs.org/browse/RESTWS-499 with a test class which have two tests. One for passing case with concept uuid and other for failing test case with exception thrown. The class need to have openmrs url, user and password changed to work as expected. The test doesnot work with demo openmrs since it has REST version 2.6, while we need 2.9.

10

@raff , looking into the issue:

It appears that the issue has fixed but under final code review process. Could you please give any idea when we can have it available in any module release. Or is there any chance that we can get the code for the fix and update and compile module ourselves, because looking into the commits I was not able to track down the actual changes done to make the concept-mapping work.

11

I will release the module by the end of this week. You could also try building the master branch.

12

I thought this issue is already resolved but am getting the same error when try to use concept map in an obs payload.

Am testing this issue on Platform 1.11.5 and am running REST Web Services 2.14-SNAPSHOT.c28691 built from the master branch.

Any help or guidance will be very helpful.

13

@werick, can you please show what that POST is that’s failing?

14

Here is the payload

{"patient":"patient_uuid", "encounterType":"b24721a5-9e7a-4a51-8257-91af569fbc4a", "encounterDatetime":"2016-03-08","obs":[{"concept":"CIEL:1436", "value":"664AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"}]
}
15

patient_uuid is a valid UUID ?

16

@lluismf: The submit work fine when using uuids. The patient uuid is ok.

Thanks

17

Here is the stack trace

http://pastebin.com/SrPJW52N

18

This error would be thrown if the concept is not found. Are you sure you have a non-required concept with that mapping?

Any chance you can run this under the debugger, with a breakpoint on ConceptResource1_9 line 42, and see what is happening in this case?

19

Apparently its not breaking on ConceptResource1_9 line 42> Not user why its calling 1_8 resource.

20

Hmm, try to put breakpoints at the first line of ConceptResource1_8.getByUniqueId and ConceptResource1_9.getByUniqueId, and see which is getting called.

(If it’s hitting the 1.8 resource but you’re on Platform 1.11, that’s a different issue to explore.)