Hello friends of clean code
Im wondering what the best approach to removing commented out code from openmrs-core is
there is quite a lot of dead stuff around, see sonar https://ci.openmrs.org/sonar/drilldown/issues/1865?&rule=squid%3ACommentedOutCodeLine&rule_sev=MAJOR
and some example candidates
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/module/ModuleClassLoader.java#L736-L777
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/hl7/impl/HL7ServiceImpl.java#L420-L428
- https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/hl7/impl/HL7ServiceImpl.java#L570-L576
seems like this was a bad habit from way back which nobody dares to remove because who know what the intention was
I suggest one issue and separate PRs for each file to ensure we handle this correctly case by case?
- treat TODOs the same way as comments? or keep them