Registration UI sectioning

rkdoc1 · September 9, 2021, 2:28pm

Hi Bahmni community, I am working on making different section in patient registration page of bahmni. can anyone please guide why we do we need the title attribute if we are not displaying it.

gsluthra · September 10, 2021, 3:26pm

You seem to be right about this. I think the Additional Information UI title is hardcoded in code to: REGISTRATION_TITLE_ADDITIONAL_PATIENT.

See code line:

github.com

Bahmni/openmrs-module-bahmniapps/blob/master/ui/app/registration/views/patientcommon.html#L251

    
      
          <div ng-if="section.canShow">
              <div class="box-container form" ng-if="::(section.attributes.length > 0 && section.title)">
                  <legend class="additional-attribute" toggle="section.expand">
                <span>
                    <i class="fa fa-caret-right"></i>
                    <i class="fa fa-caret-down"></i>
                    <strong>
                        <a ng-if="::section.translationKey" href accesskey="{{::section.shortcutKey | translate}}"
                           ng-bind-html="::section.translationKey | translate">
                        </a>
                        <a ng-if="::(section.title && !section.translationKey)" href>{{::'REGISTRATION_TITLE_ADDITIONAL_PATIENT' | translate}}</a>
                    </strong>
                </span>
                  </legend>
                  <section class="form-field-inline clearfix" ng-show="section.expand">
                      <article class="form-field" ng-repeat="attribute in ::section.attributes"
                               ng-class="::{'right-form-field' : $index%2 != 0}">
                          <attribute-types target-model="patient" attribute="::attribute" field-validation="::fieldValidation"
                                           is-auto-complete="isAutoComplete" get-auto-complete-list="getAutoCompleteList"
                                           get-data-results="getDataResults" is-read-only="isReadOnly" handle-update="handleUpdate"></attribute-types>
                      </article>

It seems the translation is being picked from this file:

github.com

Bahmni/openmrs-module-bahmniapps/blob/master/ui/app/i18n/registration/locale_en.json#L67

    
      
          "REGISTRATION_LABEL_NAME":"Name",
          "REGISTRATION_LABEL_ID":"ID",
          "REGISTRATION_LABEL_NO_RESULTS":"No more results",
          "REGISTRATION_LABEL_SUMMARY":"Summary",
          "REGISTRATION_LABEL_CLOSE_VISIT":"Close Visit",
          "REGISTRATION_LABEL_YES":"Yes",
          "REGISTRATION_LABEL_NO":"No",
          "REGISTRATION_LABEL_SAVE":"<u>S</u>ave",
          "REGISTRATION_LABEL_BACK":"<u>B</u>ack",
          "REGISTRATION_LABEL_ENTER_VISIT":"Enter <u>V</u>isit Details",
          "REGISTRATION_TITLE_ADDITIONAL_PATIENT":"Additional Patient Information",
          "REGISTRATION_TITLE_RELATIONSHIPS":"Relationships",
          "REGISTRATION_CONTENT_ENTERING_ID":"You are entering ID(s) which is ahead of the Sequence. It will create a gap in the Sequence. Do you want to continue?",
          "REGISTRATION_LABEL_SAVED" : "Saved",
          "REGISTRATION_NO_RESULTS_FOUND":"No results found",
          "REGISTRATION_INSUFFICIENT_PRIVILEGE": "You don't have privilege to do this action.",
          "REGISTRATION_LABEL_COULD_NOT_FIND_PATIENT":"Could not find patient with identifier {{patientIdentifier}}. Please verify the patient ID entered or create a new patient record with this ID.",
          "REGISTRATION_VISIT_CANNOT_BE_CLOSED":"Admitted patient's visit cannot be closed. Discharge the patient and try again",
          "REGISTRATION_CONFIRM_CLOSE_VISIT":"Are you sure you want to close this visit?",
          "REGISTRATION_LABEL_CORRECT_ERRORS":"Please correct errors in the form. Information not saved",
          "REGISTRATION_LABEL_ENTER_MANDATORY_FIELDS":"Please enter data into mandatory field(s).",

As per this documentation page, title should have reflected on screen. https://bahmni.atlassian.net/wiki/spaces/BAH/pages/34013806/Registration+App

Maybe someone else can clarify who is more familiar with this part of Bahmni. cc: @binduak @angshuonline @buvaneswariarun