Reference Application release process needs to be fixed

raff · November 12, 2015, 9:53am

As part of the last OpenMRS 2.3 release, we have released emr-api:1.11.1 with the referenceapplication:2.3-SNAPSHOT dependency. As a result emr-api:1.11.1 cannot be used as a dependency in any module, because it requires at build time referenceapplication:2.3-SNAPSHOT, which no longer exists. The issue is we couldn’t have released emr-api:1.11.1 with the referenceapplication:2.2 dependency, because it needed some dependencies declared in referenceapplication:2.3-SNAPSHOT. At the same time referenceapplicatoin:2.3-SNAPSHOT could not have been released before emr-api:1.11.1 was released. We have pretty much the same issue in all our modules importing the referenceapplication pom.

We need to change how we release the Reference Application. First we need to release a pom that we import in all Reference Application modules (let’s call it the distro pom), next we release all modules and finally the distro (zip).

It means that the distro pom would be released with versions of modules that have not been released yet, but it is “ok”, since it is just a pom declaration. The distro pom would also have to be released independently from the project that assembles the distro zip, which would be the actual release of the Reference Application. It’s not ideal so I am hoping someone has a better idea

wyclif · November 12, 2015, 8:24pm

In theory, no module should really be having a strong dependency on the reference application module since it is more like the glue that brings together everything to form the ref app distro. So emrapi needs to be fixed to have a weak dependency on RA module

raff · November 13, 2015, 12:42pm

I’m not sure what you mean by the weak dependency. I don’t know any mechanism in maven for that.

We import the reference application distro pom in modules included in the distro to manage dependency versions from one place and be able to test if they build and run correctly against the same set of dependencies.

wyclif · November 17, 2015, 1:57am

I mean no module should have RA module as a dependency in its pom file, i guess my other question is why does emrapi depend on the RA module?

raff · November 17, 2015, 1:26pm

It’s not the RA module dependency rather the RA distro dependency. Once again see

github.com

openmrs/openmrs-module-emrapi/blob/1.11.1/pom.xml#L46


    <module>api-1.10</module>
    <module>api-1.9</module>
    <module>condition-list</module>
</modules>


<properties>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <openmrsTestutilsVersion>1.3</openmrsTestutilsVersion>
    <distro.groupId>org.openmrs.distro</distro.groupId>
    <distro.artifactId>referenceapplication</distro.artifactId>
    <distro.version>2.3-SNAPSHOT</distro.version>
    <reportingModuleVersion>0.9.6</reportingModuleVersion>
    <providermanagementModuleVersion>2.3</providermanagementModuleVersion>
    <metadatasharingVersion>1.1.9</metadatasharingVersion>
    <eventVersion>2.2.1</eventVersion>
    <webservicesRestModuleVersion>2.12</webservicesRestModuleVersion>
</properties>


<dependencyManagement>
    <dependencies>
        <dependency>

wyclif · November 18, 2015, 4:22pm

That was intentional and that should be the only snapshot version allowed when releasing a module that pulls it’s dependencies from the distro