Personimage resource doesn´t available in new version

david.corrales · August 2, 2019, 9:34am

Module: EMR-API

Module Version: 1.27.0

System Version: 2.2.0

Issue or Question: Hello, I have downloaded Reference Application 2.9.0 (Individual Components for Advanced Installation) and I have deployed OpenMRS 2.9.0 in Tomcat 8 with MySQL 5.6 (and with all Add-Ons). Everything is ok…just when I started to see the available resources. In WebServices, I don´t find /personimage resource. I have been checking in other OpenMRS instances (SDK for example) and this resource is availabe. Anyone knows if this resource (/personimage) is not availabe in Ref.App. 2.9.0 (plataform 2.2.0)?

Thanks so much. Best regards.

sharif · August 2, 2019, 10:52am

@david.corrales yes person image folder has no person images which is ok my perspective,what is your main case in use of person image.or what was your idea. thanks

jwnasambu · August 2, 2019, 11:31am

@david.corrales not all modules are included on the UI. To find that module and add on your app click on System Administration - Advanced Administration - Manage modules - add or upgrade module - face list module.

mozzy · August 2, 2019, 1:16pm

@david.corrales when you say “I have been checking in other OpenMRS instances” , what does it exactly mean ?

Here is the github link for the person Image Resource. it resides in the Emrapi Module
Look at all the available resources on the Demo server here
Swagger document of the PersonImage resouce on demo server
image1366×768 54.2 KB
Here is the Swagger document for the Person Image Resource on my local instance , Reff App 2.9
image1366×768 53.6 KB

mozzy · August 2, 2019, 1:20pm

@sharif he wasnt talking about Person Images files , he was talking about Rest Resources

david.corrales · August 4, 2019, 8:58am

Hi @mozzy,

about OpenMRS instances I mean that I have tested OpenMRS SDK deploy, where I can find the EMRapi Module with Patient Image Resource (Rest Service). The problem is that if I take the OpenMRS 2.9.0 Ref.App Platform + Addons (EMRapi included) and deploy it in Tomcat 8 with MySQL 5.6, everything looks ok, but If I list the resources (…/openmrs/module/webservices/rest/apiDocs.htm) the person image resource doesn´t appear:

If I look at resources in Demo Server it appears properly, and If I check the OpenMRS SDK deployed, the resource appears too:

I don´t know why this resource doesn´t appear in my OpenMRS 2.9.0 Ref App + Addons instance. I have checked the EMRapi module, and it´s started properly in my instance.

Thanks so much. Best regards.

dkayiwa · August 4, 2019, 9:37am

Are you using the same browser? Can you share the server side log for the one where it does not appear?

david.corrales · August 4, 2019, 2:51pm

Hi @dkayiwa,

yes, I´m using the same browser. I attach the different logs: localhost_access_log.2019-08-04.txt (20.1 KB) localhost.2019-08-04.log.txt (2.2 KB) catalina.2019-08-04.log.txt (10.6 KB) openmrs.log.txt (55.7 KB)

Thanks so much! Best regards!

dkayiwa · August 5, 2019, 9:22am

Ping me when you get time and we walk through this at: https://uberconference.com/openmrs

david.corrales · August 27, 2019, 8:43am

Solved! The problem is just the @Resource annotation in EMR API module, PersonImageResouce class. Just to add “2.2.*” in supportedOpenmrsVersions

How can I send this request to the community?

Thanks so much!

mozzy · August 27, 2019, 8:52am

github.com

openmrs/openmrs-module-emrapi/blob/master/omod/src/main/java/org/openmrs/module/emrapi/rest/resource/PersonImageResource.java#L27


      
          import org.openmrs.module.webservices.rest.web.response.ResponseException;
          import org.openmrs.util.OpenmrsUtil;
          
          import java.io.FileInputStream;
          import java.io.FileNotFoundException;
          import java.io.IOException;
          import java.io.InputStream;
          import java.util.Arrays;
          import java.util.List;
          
          @Resource(name = RestConstants.VERSION_1 + "/personimage", supportedClass = PersonImage.class, supportedOpenmrsVersions = {"1.9.*", "1.10.*", "1.11.*", "1.12.*", "2.0.*", "2.1.*", "2.2.*", "2.3.*", "2.4.*", "2.5.*"})
          public class PersonImageResource extends DelegatingCrudResource<PersonImage> {
          
              @Override
              public List<Representation> getAvailableRepresentations() {
                  return Arrays.asList(Representation.DEFAULT, Representation.FULL);
              }
          
              @Override
              public DelegatingResourceDescription getRepresentationDescription(Representation rep) {
                  return new DelegatingResourceDescription();

your very true ,the resource innitialy wasnt suppoerting platform2.2.* .You can actually create a Pr for it.

dkayiwa · August 27, 2019, 8:52am

Thanks @david.corrales for sharing.

Create a ticket, and then raise a pull request while following this process.