Patient Flags Descriptor enables Flags on Start of Module

slubwama · April 17, 2019, 12:08pm

We have been having an issue of patient flags enabling the flags automatically when ever it starts even after disabling them via the interface. We discovered that this is attributed to the Descriptor which has the flags enabled automatically on start.

public Boolean enabled() { return Boolean.TRUE; }

Wondering what would be the best approach removing the option of automatic enable of flags on start. @dkayiwa @maimoonak @ssmusoke Any thoughts

dkayiwa · April 17, 2019, 8:45pm

What do you have in mind?

slubwama · April 18, 2019, 4:09am

Removing the enabled method from the Descriptor

dkayiwa · April 18, 2019, 9:19am

Can you share a link to the line of code that you are referring to?

slubwama · April 18, 2019, 9:34am

This is the Code Class I am referring to

github.com

openmrs/openmrs-module-patientflags/blob/7e59726ed24535ae97a1472d94de1c5c02a40082/api/src/main/java/org/openmrs/module/patientflags/metadatadeploy/descriptor/FlagDescriptor.java#L29


    public String evaluator() {
            return"org.openmrs.module.patientflags.evaluator.SQLFlagEvaluator";
    }


    public abstract String message();


    public abstract String priority();


    public abstract List<String> tags();


    public Boolean enabled() {
        return Boolean.TRUE;
    }
}

slubwama · April 18, 2019, 9:43am

There is a possibility of having the method an abstract.

dkayiwa · April 18, 2019, 9:46am

That looks like simply making flags enabled by default. But then overridden by the value stored in the database. https://github.com/openmrs/openmrs-module-patientflags/blob/7e59726ed24535ae97a1472d94de1c5c02a40082/api/src/main/java/org/openmrs/module/patientflags/db/hibernate/HibernateFlagDAO.java#L61

slubwama · April 26, 2019, 8:20am

And default when ever the module starts yes @dkayiwa. which doesn’t make sense for the available function of disabling the flags

dkayiwa · April 26, 2019, 8:28am

Aren’t flags stored and hence loaded from the database?

slubwama · April 26, 2019, 9:24am

@dkayiwa Flags are computed on the fly its the query that executes them that is stored.

dkayiwa · April 26, 2019, 9:35am

What could be the use of this? https://github.com/openmrs/openmrs-module-patientflags/blob/7e59726ed24535ae97a1472d94de1c5c02a40082/api/src/main/java/org/openmrs/module/patientflags/db/hibernate/HibernateFlagDAO.java#L61

slubwama · April 26, 2019, 9:36am

@dkayiwa Its a get method according to method name and what the DAO method does…

dkayiwa · April 26, 2019, 10:04am

Isn’t that method retrieving a flag that is already stored in the database?

slubwama · April 26, 2019, 1:35pm

Yes It does.

dkayiwa · April 26, 2019, 1:58pm

So the database stored enabled value will override the default one.

slubwama · April 26, 2019, 1:59pm

@dkayiwa Yes That is true

dkayiwa · April 26, 2019, 2:21pm

Therefore, if you say that a flag, which was disabled and saved in the database as so, comes out enabled, then you need to check the database to confirm that your changes were persisted.