OpenMRS Platform 2.3.0 Released!

ruhanga · February 6, 2020, 10:35am

Ohh, yes. This has to do with the SDK. I would think that up till now, the SDK is unaware of OWAs when deploying a distribution. The packaged OWAs are not copied to their folder just as the modules are during the initial setup process.

dkayiwa · February 6, 2020, 10:44am

@ruhanga i thought the addon manager is bundled with the platform. Not so?

ruhanga · February 6, 2020, 10:55am

Yes indeed @dkayiwa. There is however a difference in deployment with the SDK. My understanding of the SDK plugin is, that it deploys a distribution like the platform from its artifacts. Up till now, these are openmrs-core and specified modules in the associated distro.properties file. It seems though, that the owa artifacts are ignored. I briefly looked into SetupIntegrationTest.java and this seems to be case.

dkayiwa · February 6, 2020, 11:46am

Do we have a ticket for that?

ruhanga · February 6, 2020, 12:17pm

Thanks for pointing this out @dkayiwa. I’ve opened SDK-250 to address the issue. I’d like to make it ready for work.

dkayiwa · February 6, 2020, 3:30pm

@ruhanga you should now be in position to make it ready for work.

mozzy · February 6, 2020, 3:38pm

Sure , the same problem when deploying reff app with SDK , it doesnt deploy OWAs

dkayiwa · February 6, 2020, 6:51pm

@ruhanga the ticket is not well curated for one to understand what exactly is the problem. You need to give some more details like how to reproduce, links to the relevant talk threads, and anything else that would be useful to some one new.

ruhanga · February 6, 2020, 8:36pm

Surely @dkayiwa. Thanks for the heads up on this. I have updated the ticket.

cintiadr · February 7, 2020, 12:09am

I’m very confused.

The docker image we deploy to uat-platform is generated using the SDK, specifically version 3.12.4. So I’m very confused how running the SDK locally would yield any different result from using the docker image from dockerhub (which is generated from the SDK).

Can someone explain to me the difference?

ruhanga · February 7, 2020, 6:52am

Thanks @cintiadr. When generating docker images, it’s evident that the command we use, a different flavour of the setup command - build-distro, surely downloads owa artifacts and these are installed on deployment. This behaves as expected.

github.com

openmrs/openmrs-sdk/blob/master/maven-plugin/src/main/java/org/openmrs/maven/plugins/BuildDistro.java#L210-L212


File owasDir = new File(tempDir, "bundledOwas");
owasDir.mkdirs();
downloadOWAs(targetDirectory, distroProperties, owasDir);

What we would like to achieve is for this setup command when creating a new server, to do similarly what build-distro does.

cintiadr · February 7, 2020, 10:33am

Ooooh I see, thanks for the explanation