Old Doclet API Removed and replaced with a New Doclet Api in openJDk 11

irenyak1 · May 28, 2019, 5:51am

Continuing the discussion from Upgrading From jdk 8 to OpenJDK 11:

CC @dkayiwa , @samuel34 , @mozzy please may you look into this issue.

mozzy · May 28, 2019, 6:12am

Looking at the error logs [ERROR] /home/irynah/Openmrs-Projects/openmrs-core/tools/src/main/java/org/openmrs/tools/doclet/ShouldTaglet.java:[143,1] error: method does not override or implement a method from a supertype

The Old Doclet API in java 8 was deprecatd and finally removed in java 11, and replaced with another new Doclet API. To Upgrade our Core from java 8 to openjdk 11, it will require some little bit of refactoring some code.

irenyak1 · May 28, 2019, 6:18am

@mozzy will you refactor the code today so we can close the ticket?

mozzy · May 29, 2019, 6:46am

The simpe aproach would be as easy doing a simple reafactoring in our code to use the new Doclet API (which @irenyak1 you can do ) ,though that would mean ,we completely break the backward compatibility with lower versions of java less than java 11,

Could there be any other approach we can take and still keep the backward compatibility with lower versions of java especially java 8 ??

cc @dkayiwa @dev3 @dev4 @dev5

irenyak1 · May 29, 2019, 6:50am

@mozzy would it really be wise to break the backward compatibility?

mozzy · May 29, 2019, 6:53am

@irenyak1 It wouldnt be the best alternative ofcourse, but let me first wait for another Alternative from other devs as am also trying to see an option

dkayiwa · May 30, 2019, 8:06pm

Does everything else compile on Java 11 if you delete the ShouldTaglet.java file?