Officially deprecating scrap (to create JIRA tickets)

cintiadr · September 29, 2018, 7:22am

Hi everyone,

A while ago, a tool called ‘scrap’ was created in order for users to report bugs straight from OpenMRS.

openmrs/openmrs-contrib-scrap/blob/master/scrap.php

<?php

# Basic JIRA information
$host = "issues.openmrs.org";
$pid = 10186;
$issuetype = 6;

# Trim the summary
$summary = substr(urlencode(trim($_POST["errorMessage"])), 0, 254);

# Debug and get version
$version = explode(" ", $_POST["openmrs_version"]);

# Clean the description
$description = "Version: ".$_POST["openmrs_version"]."%0D%0AImplementation ID: ".$_POST["implementationId"]."%0D%0AUser ID: ".$_POST["username"]."%0D%0AStarted Modules: ".$_POST["startedModules"]."%0D%0A%0D%0ASummary:%0D%0A".$summary."%0D%0A%0D%0ADescription:%0D%0A".urlencode($_POST["stackTrace"]);

# Translate the Version reported into the JIRA version ID
if ($version[0] == "1.7.0") $jiraVersion = 13078;
if ($version[0] == "1.6.1") $jiraVersion = 13077;
if ($version[0] == "1.8.0") $jiraVersion = 13080;

This file has been truncated. show original

You can see the line in openmrs-core referencing it:

github.com

openmrs/openmrs-core/blob/4a0feb8da351088f25fdc4e6d324a1f277aa3410/api/src/main/java/org/openmrs/util/OpenmrsConstants.java#L885


		                "false",
		                "Whether or not to display the patient name in the patient dashboard title. Note that enabling this could be security risk if multiple users operate on the same computer.",
		                BooleanDatatype.class, null));
		
		props.add(new GlobalProperty(GLOBAL_PROPERTY_DEFAULT_THEME, "",
		        "Default theme for users.  OpenMRS ships with themes of 'green', 'orange', 'purple', and 'legacy'"));
		
		props.add(new GlobalProperty(GLOBAL_PROPERTY_HL7_ARCHIVE_DIRECTORY, HL7Constants.HL7_ARCHIVE_DIRECTORY_NAME,
		        "The default name or absolute path for the folder where to write the hl7_in_archives."));
		
		props.add(new GlobalProperty(GLOBAL_PROPERTY_REPORT_BUG_URL, "http://errors.openmrs.org/scrap",
		        "The openmrs url where to submit bug reports"));
		
		props.add(new GlobalProperty(GP_SEARCH_WIDGET_BATCH_SIZE, "200",
		        "The maximum number of search results that are returned by an ajax call"));
		
		props
		        .add(new GlobalProperty(
		                GP_SEARCH_WIDGET_IN_SERIAL_MODE,
		                "false",
		                "Specifies whether the search widgets should make ajax requests in serial or parallel order, a value of true is appropriate for implementations running on a slow network connection and vice versa",

This tool didn’t have any recent version of OpenMRS, it wasn’t updated. It’s not running for more than a year and no one appeared to have missed it.

Unless someone wants to take over it and add it to a container, I’d recommend to just archive the repository.

dkayiwa · September 29, 2018, 6:04pm

What do you suggest that we replace this global property with?

r0bby · September 30, 2018, 3:36am

Have them create JIRA tickets by hand?

samuel34 · September 30, 2018, 9:58am

We possibly retire/stash it

cintiadr · September 30, 2018, 12:45pm

I suppose you can even delete the property and remove any references to it.

It doesn’t seem anyone is actually following it at all, as no one has complained.

dkayiwa · October 1, 2018, 11:11am

Fair enough!