OCL for OpenMRS squad

Projects Open Concept Lab
61

Here is a link to the recording: 2020-01-15 OCL for OpenMRS Squad and we have notes with action items as well.

1 Like
62

@tendomart hope this got you covered,by the way you had said to do some works around OCL with the guidance of raff.will you get some time for this,if so kindly get to raff and we get things moving

63

Thanks @jennifer .

Am getting to him.

1 Like
64

great thanks

65

@tendomart hi martin,how far with raff have you reached?

66

@tendomart hi martin are you here?

67

Will let you know when i get feed back from @raff

1 Like
68

Please join us for the OCL/OCL for OpenMRS Squad meeting to be held today(Wednesday, January 22, 2020) and every Wednesday : https://iu.zoom.us/j/750230470

  • 3pm UTC
  • 6pm EAT
  • 10AM EST (Boston)
  • 9AM CST (Chicago)
  • 7AM (Seattle)

Agenda

  • [Discussing the OCL sprint 24

Squad: @herbert24 @mozzy @jennifer @jecihjoy @jdick @kuang @whiscard @dkayiwa @darius @akanter @burke @jwnasambu @irenyak1 @tendomart @mseaton @mogoodrich @karuhanga @paynejd @ibacher

69

hi every one,has any one noticed these errors of travis https://pastebin.com/iAd2yM1v even after making a simple change in (openmrs-ocl-client) for a created pull request cc @jecihjoy @paynejd @dkayiwa @karuhanga

70

@herbert24 Do you have yesterday’s recording ?

The error log is too long , can you produce a concise error so support may come early enough.

71

Hi every one,lets kindly use this thread for all the OCL discussions for an easy follow up.@mozzy @jennifer @jecihjoy @jdick @kuang @whiscard @dkayiwa @darius @akanter @burke @jwnasambu @irenyak1 @tendomart @mseaton @mogoodrich @karuhanga @paynejd @ibacher @ball

72

On yesterday’s call I said I would help look into some blocker issue. Please give me the details of what I’m supposed to be researching.

73

hi @darius just made a pr here https://github.com/openmrs/openmrs-ocl-client/pull/577 and tagged you

74

@herbert24, I see the problem you’re describing. I tried building locally and it passed, and I’m not going to have time to debug why this is failing in travis anytime soon.

At a first glance, though, I see that the version of node was upgraded a couple days ago, so that’s the likely cause: https://github.com/openmrs/openmrs-ocl-client/commit/c2623c5884d09f6217c00cf627ecc1d467ff0815

Also, let me suggest how I think you should have phrased this:

There is a problem in the openmrs-ocl-client CI pipeline. It fails to build even a trivial pull request. See this example: https://github.com/openmrs/openmrs-ocl-client/pull/577.

This is a blocker. It prevents us from making even the simplest change. @dkayiwa @karuhanga, who can help us research this?

1 Like
75

hi @jecihjoy @dkayiwa could you be having any solution on this

76

Maybe try changing the node version number in .travis.yml in your PR? Or, if you have priviliges on this repository you can revert dkayiwa’s commit and try your PR again.

1 Like
77

i changed the node version in my pr but it still breaks with the same error!!

78

Fixed at https://github.com/openmrs/openmrs-ocl-client/commit/9f13b199711331a9e68105a41fc1c1a2b1b3194f

The reason why it was not failing locally for those who already had ever built it before, was because package-lock.json had already locked to specific versions of dependencies in the package.json file. You had to first delete the package-lock.json file and node_modules folder in order to reproduce it locally.

Because we use the caret(^) for dependency versions in the package.json file, it means that building, automatically updates to the latest minor and patch versions for dependencies and their sub dependencies. Because they are not major version upgrades, they not supposed to be breaking changes. But unfortunately, not all developers respect this. Hence we ended up with the current problem.

2 Likes
79

thanks alot for the solving this and elaborating more on the cause of of the error.@dkayiwa

80

Hi every one,this is a gentle reminder to join us for the OCL/OCL for OpenMRS Squad meeting to be held today(Wednesday, January 29, 2020) and every Wednesday : http://www.uberconference.com/openmrs

  • 3pm UTC
  • 6pm EAT
  • 10AM EST (Boston)
  • 9AM CST (Chicago)
  • 7AM (Seattle)

Agenda

Sprint 24 OCL updates

Squad: @herbert24 @mozzy @jennifer @jecihjoy @jdick @kuang @whiscard @dkayiwa @darius @akanter @burke @jwnasambu @irenyak1 @tendomart @mseaton @mogoodrich @karuhanga @paynejd @ibacher