NPE when evaluating Quick Reports

werick · June 4, 2015, 2:27pm

We are experiencing a case where our quick reports are not running. I’ve debugged the error and noticed that an NPE is being thrown when this report is being evaluated.

The line that fails is in QuickReportsServlet.java and the function is:

 Velocity.evaluate(velocityContext, report, this.getClass().getName(), getTemplate(reportType));

Any insights on how to resolve this will be very helpful.

werick · June 16, 2015, 6:07am

@mseaton, Kindly help us look into the above Issue.

Thanks

Erick

darius · June 16, 2015, 1:09pm

@werick, you should share the complete stack trace. Also, where is “Quick Reports” in the UI?

mseaton · June 16, 2015, 1:42pm

I think we’d need a bit more information to help you debug this. This is a pretty ancient and not-really-supported feature, buried in the legacy web application. Looking at the code, it even has a hard-coded concept id for “RETURN VISIT DATE” here:

github.com

kishoreyekkanti/openmrs/blob/master/web/src/main/java/org/openmrs/web/servlet/QuickReportServlet.java#L111


	private void doReturnVisitDate(VelocityContext velocityContext, PrintWriter report, HttpServletRequest request)

	        throws ServletException {

		ObsService os = Context.getObsService();

		EncounterService es = Context.getEncounterService();

		LocationService ls = Context.getLocationService();

		ConceptService cs = Context.getConceptService();

		

		DateFormat dateFormat = Context.getDateFormat();

		velocityContext.put("date", dateFormat);

		

		Concept c = cs.getConcept(new Integer("5096")); // RETURN VISIT DATE

		Calendar cal = Calendar.getInstance();

		

		Date start = new Date();

		Date end = new Date();

		

		String startDate = request.getParameter("startDate");

		String endDate = request.getParameter("endDate");

		String location = request.getParameter("location");

		

		if (startDate != null && startDate.length() != 0) {

So I might not expect this to work correctly for most implementations.

Is there any kind of an error in the log file that you are seeing?

werick · June 16, 2015, 1:46pm

Quick Reports are under maintenance section within the admin page.

Here is the stack trace http://pastebin.com/83Yd5M2y

burke · June 19, 2015, 7:06pm

@werick, based on the stacktrace, it appears to be an NPE coming when parsing the “RETURN VISIT DATE THIS WEEK” velocity template.