New version of JSP that can be found in Maven central

Development
1

Hello Devs, I am having a challenge upgrading javax.servlet:jsp-api library. From the central Maven repository it shows that this dependency is now specified as

<dependency>
    <groupId>javax.servlet.jsp</groupId>
    <artifactId>javax.servlet.jsp-api</artifactId>
    <version>2.3.3</version>
</dependency>

However in our core it is specified as

<dependency>
	<groupId>javax.servlet</groupId>
	<artifactId>jsp-api</artifactId>
	<version>2.0</version>
</dependency>

So when I am looking out for the newest version of the library in the maven central repository, I am directed to the former which is not exactly specified as the one in the Openmrs core.

My question, do we need to do some refactoring in the code to match the new format of the library? Here is the error log.

cc @dkayiwa, @mozzy, @ruhanga

2

@irenyak1 did you replace the format in the pom with

<dependency>
    <groupId>javax.servlet.jsp</groupId>
    <artifactId>javax.servlet.jsp-api</artifactId>
    <version>2.3.3</version>
</dependency>
3

No @tendomart I haven’t replaced it.

4

First question would be, if you switch to the new format, does everything compile successfully and the reference application run without any errors?

1 Like
5

Not at all @dkayiwa. when I change the main pom and the web pom to

<dependency>
    <groupId>javax.servlet.jsp</groupId>
    <artifactId>javax.servlet.jsp-api</artifactId>
    <version>2.3.3</version>
</dependency>

I get this error

6

Do you have a pull request with the changes that you have made?

7

Let me run it again and see if it builds or not then i make a PR @dkayiwa

8

It still fails to build and here is the error log

I have made a commit to the old PR here