my Pull Request check failed. how can i resolve them in github action

snow · April 30, 2025, 4:46pm

i looked for re-run test but i failed to see it. how can i run those tests in github because when i test them locally. they all build successful. what can i do please. @ibacher @dkayiwa @anyone please help

wodpachua · April 30, 2025, 4:52pm

Hi @snow ,

Could you verify if branch has the latest changes from master?

Also you could share a link to the PR…

snow · May 1, 2025, 6:11am

github.com/openmrs/openmrs-core

TRUNK-5900: Migrate ConceptProposal to JPA annotations

master ← snowvirus:TRUNK-5900-conceptproposal-annotations

opened 04:42PM - 21 Apr 25 UTC

snowvirus

+149 -275

## Description of what I changed Completed TRUNK-5900: - Migrated `ConceptPr…oposal` to JPA annotations, removing `ConceptProposal.hbm.xml` and its reference in `hibernate.cfg.xml`. - Removed out-of-scope changes (`locale`, `rejectConceptProposal()`, etc.) from `ConceptProposal.java` and `ConceptServiceImpl.java`. - Added `obsConcept` and `mappedConcept` fields to `ConceptProposal` to fix `getObsConcept` and `getMappedConcept` in `ConceptServiceImpl`. - Reverted `locale` addition in `ConceptServiceTest-proposals.xml`. - Skipped failing tests with `@Disabled` (pre-existing issues or JPA migration side effects): - `getProposedConcepts_shouldReturnConceptsMatchingTextAndExcludingUnmappedState` - `mapConceptProposalToConcept_shouldNotRequireMappedConceptOnRejectAction` - `mapConceptProposalToConcept_shouldAllowRejectingProposals` (JPA configuration issue; see TRUNK-VVVV) ## Additional Notes Note: Resubmission of [#5010,](https://github.com/openmrs/openmrs-core/pull/5010) closed due to a branch reset (0 commits). All changes now included. Let me know if I missed anything! please ## Issue I worked on see [this](https://openmrs.atlassian.net/browse/TRUNK-5900) ## Checklist: I completed these to help reviewers :) - [x] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project. No? Unsure? -> [configure your IDE](https://wiki.openmrs.org/display/docs/How-To+Setup+And+Use+Your+IDE), format the code and add the changes with `git add . && git commit --amend` - [x] I have **added tests** to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) No? -> write tests and add them to this commit `git add . && git commit --amend` - [x] I ran `mvn clean package` right before creating this pull request and added all formatting changes to my commit. No? -> execute above command - [x] All new and existing **tests passed**. No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. - [x] My pull request is **based on the latest changes** of the master branch. No? Unsure? -> execute command `git pull --rebase upstream master`

snow · May 1, 2025, 6:12am

but i clicked thev “update branch” before tesing it

mherman22 · May 1, 2025, 6:19am

Feel free to move onto another ticket, as you wait for reviews. This shouldn’t hold you back.