MVN build failing on Github

[suubi7 (SSEBAANA Suubi Joshua)]

Hallo Community I am working on this ticket Log in - OpenMRS Issues I have put back the method in HibernatePatientsDAO.java that queried only using patient identifier. I run a mvn clean install and clean package before pushing the code to the repository and all tests passed just fine, the build was succesful. But the checks on github are failing escpecially those of mvn build. What could be the problem in this case. Here is the PR: TRUNK-5362:Issue with method in EncounterService causing extreme slow… by suubi-joshua · Pull Request #4303 · openmrs/openmrs-core · GitHub

@jwnasambu @kdaud @dkayiwa @jayasanka

[dkayiwa (Daniel Kayiwa)]

What happens when you locally run this command?

mvn test -Dtest=VisitValidatorTest -Dsurefire.failIfNoSpecifiedTests=false

[suubi7 (SSEBAANA Suubi Joshua)]

When I run it. It gives these two errors. Same as those on Github

[dkayiwa (Daniel Kayiwa)]

What happens after putting Context.flushSession(); before Context.getEncounterService().saveEncounter(encounter); in each of those failing tests?

[suubi7 (SSEBAANA Suubi Joshua)]

The tests pass now thanks @dkayiwa .

[suubi7 (SSEBAANA Suubi Joshua)]

@dkayiwa

Context.flushSession();

@dkayiwa Whenever am pushing code changes for core it seems am getting the same Validator test error. Is it on my end alone or it needs to be issued

[dkayiwa (Daniel Kayiwa)]

Feel free to create a ticket for it and raise a corresponding pull request.

[suubi7 (SSEBAANA Suubi Joshua)]

@dkayiwa Alright

Created Ticket [TRUNK-6177] Fix the StackOver flow error in the VisitValidatorTest. - OpenMRS Issues [Needs Assessment]

PR: TRUNK-6177 Fix the StackOver flow error in the VisitValidatorTest. by suubi-joshua · Pull Request #4311 · openmrs/openmrs-core · GitHub