More Tips for making good Pull requests for GCI students

Hi all,

Its awesome mentoring GCI this year, I have reviewed work that really looks good and even potentially learnt new stuff from these students. Thanks to all students participating in GCI with Openmrs this year.

  • For tasks that require a student to make a Pull Request to any of the openmrs repo, make sure you first look at Pull Request Tips . On addition to the above, also make sure you claim the Jira issue you are working on if just incase its with status Ready for Work and change its status to code review.

  • You should also make sure add the link to your GCI task instance for quick mentor review/approval to that Pull Request possibly as a comment.

Reagards

~Samuel

3 Likes

Thanks @samuel34 for sharing!