module config version confusion

Development
,
1

Hello!

I wanted to update my modules configVersion in its config.xml and had a look at

https://wiki.openmrs.org/display/docs/Module+Config+File

where it says that version 1.6 exists but when I set the the verison in my config.xml like

<module configVersion="1.6">

and upload the module on openmrs 2.0.0 SNAPSHOT Build 001ba8 with legacy ui I get that the version is invalid which judging by the code https://github.com/openmrs/openmrs-core/blob/2.0.x/api/src/main/java/org/openmrs/module/ModuleFileParser.java#L66-L72

I understand that it isnt valid.

Is the wiki ahead of its time? Or is the Config.dtd version mentioned there not the same as the version element in the file itself?

2

@teleivo very nice catch! Do you have some time to create a pull request? :slight_smile:

3

haha, is the only change needed to add the other valid versions? then yes :wink: or do we need to match the config versions against the running openmrs version?

4

PR https://github.com/openmrs/openmrs-core/pull/1811

issue https://issues.openmrs.org/browse/TRUNK-4899

5

That was fast. Thanks @teleivo :slight_smile: