Missing PatientId

reagan · January 29, 2020, 11:40am

While working on RefApp on this ticket https://issues.openmrs.org/browse/RA-950, I came across an error when editing a Visit Date. https://pastebin.com/tFNNG8MP is thrown when you save…While the visit date change is well persisted;the response from the serve is not graceful. Can a ticket be created for it? @dkayiwa @mogoodrich @ruhanga @mozzy

ruhanga · January 29, 2020, 12:22pm

Thanks @reagan, did you manage to reproduce this on demo and qa-refapp? If yes, you may please go ahead to create a ticket for this to unblock you if there’s not one already.

reagan · January 29, 2020, 12:27pm

@ruhanga I tested it locally with sdk of latest snapshot and on qa-refapp as well, demo is currently unavailable…

ruhanga · January 29, 2020, 12:39pm

I just reset the demo, you may as well go ahead to test on it. Feel free to create a ticket that’ll solve your blocker.

reagan · January 29, 2020, 1:02pm

On demo-server it redirects well…

reagan · January 30, 2020, 11:20am

@ruhanga It seems a recent PR merge edited the redirect URL…

ruhanga · January 30, 2020, 8:16pm

Thanks @reagan. @mozzy could this be bootstrap related?

reagan · January 30, 2020, 8:23pm

I think it’s an issue with the controller… The searchparams it gives on return find in this file…omod/src/main/java/org/openmrs/module/coreapps/fragment/controller/visit/VisitDatesFragmentController.java…

ruhanga · January 30, 2020, 8:52pm

Okay @reagan , looks like there is a jQuery conflict before/after a successful post is made though. Here is a caught error in the Chrome Dev tool,

TypeError: $.getJSON(...).success is not a function

ruhanga · January 30, 2020, 9:18pm

@reagan you could go ahead to create a ticket that resolves this. The success() method was deprecated in preference of done() in jQuery 3.4.1 . This means correcting the occurrences of this method such as the one below in that js file.

github.com

openmrs/openmrs-module-coreapps/blob/master/omod/src/main/webapp/resources/scripts/custom/visits.js#L134


/**
 * Functions used to edit visit dates (uses VisitDatesFragmentController)
 */
visit.showEditVisitDateDialog = function(visitId) {
    if (!editVisitDialogs[visitId]) {
        editVisitDialogs[visitId] = emr.setupConfirmationDialog({
            selector: '#edit-visit-dates-dialog-' + visitId,
            actions: {
                confirm: function() {
                    var url = emr.fragmentActionLink("coreapps", "visit/visitDates", "setDuration");
                    $.getJSON(url, $('#edit-visit-dates-dialog-form-' + visitId).serialize()).success(function(data) {
                            if (data.success) {
                                jq('#edit-visit-dates-dialog-form-' + visitId + ' .icon-spin').css('display', 'inline-block').parent().addClass('disabled');
                                // TODO Do we need to update this to specify return url, or is this link only going  to ever be used from the old visits view? 
                                window.location.search = data.search;
                            }
                        }
                    );
                    return false;
                }
            }

reagan · January 31, 2020, 6:35am

Alright then

reagan · February 2, 2020, 1:00pm

@ruhanga Kindly review the issue here and advice on how to make it more clear. https://issues.openmrs.org/browse/RA-1696. Kind regards…

reagan · February 2, 2020, 6:36pm

The fix works fine…Will send the PR when its made ready for work.

ruhanga · February 3, 2020, 6:55am

Thanks @reagan. @mozzy could you transition RA-1696 to ready for work? Thanks.

dkayiwa · February 3, 2020, 7:56am

@ruhanga i have just given you admin permissions to that JIRA project. So you should also be in position to do the needful.

ruhanga · February 3, 2020, 8:11am

Thanks @dkayiwa. @reagan I hope you can now get the pull request through.

ruhanga · February 28, 2020, 12:07pm

Thanks @reagan, I just merged the PR on RA-1696

reagan · February 28, 2020, 12:40pm

Ur welcome @ruhanga

mozzy · February 28, 2020, 2:32pm

@reagan deserves a dev2 badge for the geat work he as done in RA

dkayiwa · February 29, 2020, 7:16pm

Can you initiate a talk post?