Make Local Language Name Fields Mandatory in Registration first page using config parameters and add localisation to its placeholder

Software Bahmni
1

We are planning to work on two enhancements in Registration page:

  1. Make Local Language Name Fields Mandatory in Registration first page using config parameters
  • Currently, bahmni supports all the personAttributes to be mandatory fields in Registration page except for name in local language.
  • We can make changes in the code to read the local language name related person attributes from the same mandatoryPersonAttributes config parameter to check if the field is mandatory or not just like other person attributes.
  1. Add localisation to the placeholder for Local language name fields
  • Currently, the placeholder text for local language name fields is getting picked from its respective person attributes description in OPENMRS
  • And the label for local language name is same as the placeholder text for givenNameLocal(First Name in Local Language) which might create confusion in some scenarios.
  • As Localisation changes are not present in the Registration html page for local language name, adding those changes here would be helpful in differentiating the label and the placeholder.

We would appreciate feedback and inputs on the same.

@angshuonline @gsluthra @michaelbontyes @buvaneswariarun @akhilmalhotra @mksd @swedhan @binduak @muhima08 @thomasrod @tarunshettygari

2
  1. Good idea to include on “mandatoryPersonAttributes”
  2. localising labels for person attribute - we have already worked on bringing the capability in 0.93. You need to introduce a label KEY following a convention. @buvaneswariarun can say more. Also check card BAH-990. If this is not respected for givenNameLocal, then you may need to fix that.

on the other hand, I am wondering why we are using attributes for names or if thats fixed? OMRS supports multiple names against different languages.

3

@angshuonline Checked with Buvana, Localisation changes were not done for Local language names.

4

Hi @angshuonline @binduak @muhima08 @buvaneswariarun @tarunshettygari @supriyam This is the PR link for making the Local Language Name Fields Mandatory in Registration first page using config parameters and add localisation to its placeholder

5

Left some comments. As commented earlier, would have been much better if you had leveraged the OMRS support for names in respective locales. Using person attribute is easy but works for a single locale and you don’t know which locale it is for.