I think there is a logging confusion mixup going on in openmrs-core. Please help me understand if we should clean this up or if I am wrong here
In the openmrs-core root pom we exclude the apache commons-logging dependency coming from springframework. I assume this is because we want to use the logging facade https://www.slf4j.org/ that we import which in turn delegates to the log4j as the logging implementation. This all seems like we try to use springs approach documented here http://docs.spring.io/spring/docs/4.1.4.RELEASE/spring-framework-reference/htmlsingle/#overview-not-using-commons-logging
But if you search in the code for apache.commons.logging you find quite a bit of classes that depend on it. For example ConceptReferenceTermEditor; there are many more.
- Should I create an issue with fixed in release 2.2.0 that will replace all occurrences of the apache.commons.logging with slf4j AND eliminate the apache.commons dependency that seems to slip in somewhere by another dependency
- Add an entry to the https://wiki.openmrs.org/display/docs/Java+Conventions that tells devs to use the slf4j
- Add a rule in Checkstyle/PMD that will flag the use of apache.commons.logging