legacyui conceptForm necessary privileges and require tag

teleivo · September 13, 2016, 1:05pm

Hello!

I created role “radiology admin” which should be able to create/edit concepts.

While figuring out which privileges are needed to access the conceptForm.jsp I see that the jsp only requires

openmrs/openmrs-module-legacyui/blob/master/omod/src/main/webapp/dictionary/conceptForm.jsp#L3


      
          <%@ include file="/WEB-INF/view/module/legacyui/template/include.jsp"%>
          
          
<openmrs:require privilege="Manage Concepts" otherwise="/login.htm" redirect="/dictionary/concept.form" />
          
          
<c:choose>
          	<c:when test="${command.concept.conceptId != null}">
          		<openmrs:message var="pageTitle" code="Concept.edit.title" scope="page" arguments="${command.concept.name}"/>
            	</c:when>
            	<c:otherwise>
            		<openmrs:message var="pageTitle" code="Concept.creatingNewConcept.title" scope="page"/>
            	</c:otherwise>
            </c:choose>

“Manage Concepts” but it actually also requires:

Get Forms (to show the Concept Usage like “Obs for this concept: 0”)
Get Observations
Get Patient Programs

otherwise you get:

which is weird since the user is allowed to “Manage Concepts” so he should see the concept he was able to lookup.

He should simply not see the concept stats/usage in obs.

Proposing solution:

Add a hasPrivilege tag around the concept sidebar portion concerned with showing the stats:

github.com

openmrs/openmrs-module-legacyui/blob/master/omod/src/main/webapp/dictionary/conceptSidebar.jsp#L19-L67


      
          <openmrs:hasPrivilege hasAll="true" privilege="Get Forms,Get Observations,Get Patient Programs" >
          	<fieldset>
          		<legend><openmrs:message code="Concept.usage" /></legend>
          		<c:if test="${command.concept.conceptId!=null}">
          		<h4><openmrs:message code="dictionary.numobs" arguments="${command.numberOfObsUsingThisConcept}" /></h4>
          
          
		<c:if test="${fn:length(command.questionsAnswered) > 0}">
          			<h4><openmrs:message code="dictionary.questionsAnswered" /></h4><ul>
          			<c:forEach items="${command.questionsAnswered}" var="question">
          				<li><a href="concept.htm?conceptId=${question.conceptId}"><openmrs:format concept="${question}" /></a></li>
          			</c:forEach></ul>
          		</c:if>
          
          
		<c:if test="${fn:length(command.containedInSets) > 0}">
          			<h4><openmrs:message code="dictionary.containedInSets" /></h4><ul>
          			<c:forEach items="${command.containedInSets}" var="set">
          				<li><a href="concept.htm?conceptId=${set.conceptSet.conceptId}"><openmrs:format concept="${set.conceptSet}" /></a><br/></li>
          			</c:forEach></ul>
          		</c:if>

This file has been truncated. show original

dkayiwa · September 13, 2016, 3:01pm

@teleivo i like your proposal. It makes perfect sense!

teleivo · September 14, 2016, 9:04am

solved here https://issues.openmrs.org/browse/LUI-102