JIRA issues + GitHub PRs

How does one solve JIRA issues and send issue specific pull requests/commit messages on GitHub?

@avijitghosh82 check if these are helpful https://wiki.openmrs.org/display/docs/Pull+Request+Tips and https://wiki.openmrs.org/display/docs/Using+Git

1 Like

You should try and read the documentation first. OpenMRS-Using Git
In a nutshell:

  1. Claim the issue. Ask for information if needed in the form of a comment and wait for a senior dev/relevant dev to reply. More than often, reading past comments should suffice

  2. Always create a branch off the target branch. Also, unless specifically mentioned, always work on the master branch. To create an issue branch for ticket TRUNK-4234 off the master branch for instance, you git checkout -b TRUNK-4234 master

  3. Add all the files you have changed to the staging area in git. e.i : git add -A

  4. Commit these files. git commit -m"Enter commit message"

  5. Push them to your local repository. git push origin TRUNK-4234

  6. Go to your repository and create create a PR from your branch to the target branch

  7. After creating PR, click on Request Code Review on the Ticket page and paste the PR link. A dev will comment on the ticket and get back to you.

  8. Create commits for further issues on the same branch for fixing further issues in the ticket.

  9. When it is merge-ready, the dev will tell you. That is when you squash your commits, issue a final commit and then hopefully it is merged :slight_smile:

Hope this helps! :smiley:

Thank you so much and forgive my silly questions. Our time zones don’t match up so IRC is a problem. I had also mailed the project lead which, in hindsight, was a bad idea considering he must be busy. I shall keep this in mind.

Thanks again!

The IRC is active 24/7. You can always find some or the other devs willing to help you out. Feel free to ping me if you have any questions :slight_smile: If you have some major issues/questions, you can attend the scrum meeting at 20.00 hrs IST. That’s a good time to meet the devs and resolve relevant, important questions

Thanks.this is very helpful…