Issue with Identifier length while searching

mahitha · February 1, 2018, 9:30am

We have one identifier with length of 21 characters. When we are searching with this identifier we are not getting the result even though there is patient with this identifier but when we remove one char from the identifier and search, we are getting the results.

@angshuonline, @darius, @shruthipitta could anyone tell us is there any limitation on identifier length to search?

shruthipitta · February 1, 2018, 9:59am

Is this in registration screen? Do you see any error in the network call? @mahitha

mahitha · February 1, 2018, 10:38am

There is no any error in the network call, the result is empty list. This is the message we are getting when we are searching with more than 20 characters in identifier field.

darius · February 1, 2018, 6:24pm

I peeked at the code briefly and I didn’t see any limit of 20 characters.

To investigate this, you might try changing the test data for this file to have a longer identifier, and then run the test:

github.com

Bahmni/bahmni-core/blob/master/bahmnicore-api/src/test/java/org/bahmni/module/bahmnicore/dao/impl/BahmniPatientDaoImplLuceneIT.java

package org.bahmni.module.bahmnicore.dao.impl;

import org.bahmni.module.bahmnicore.BaseIntegrationTest;
import org.bahmni.module.bahmnicore.contract.patient.response.PatientResponse;
import org.bahmni.module.bahmnicore.dao.PatientDao;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.openmrs.Patient;
import org.springframework.beans.factory.annotation.Autowired;

import java.util.List;
import static junit.framework.Assert.assertEquals;
import static junit.framework.Assert.assertFalse;
import static junit.framework.Assert.assertNull;
import static junit.framework.Assert.assertTrue;

public class BahmniPatientDaoImplLuceneIT extends BaseIntegrationTest {
    @Autowired

This file has been truncated. show original

mahitha · February 2, 2018, 9:04am

I ran the test cases by changing the test data. Till 20 characters test cases were passing, if the identifier length exceeds more than 20 characters, tests are failing.

shruthipitta · February 2, 2018, 12:03pm

This is causing the issue. Since its maxGramSize is 20 its not able to search when length is beyond that. This happening because we use AnywhereAnalyzer in Bahmni core API: https://github.com/Bahmni/bahmni-core/blob/511e3aed6351b2bb35fa0a4471e9c526a67c1735/bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/dao/impl/PatientDaoImpl.java#L108

darius · February 5, 2018, 11:13pm

@shruthipitta is there a reason that we had to write a custom Bahmni lucene query for this and we couldn’t leverage what’s built in to openmrs-core?

Or rather: would we be able to preserve our expected behavior just by using OpenMRS code?

shruthipitta · February 15, 2018, 11:44am

@darius I had a quick look at the code and I dont see any obvious reason as to why we implemented it in Bahmni instead of using the OpenMRS query. I think we have to get rid of the redundant code. However even the Openmrs API should have the same issue, isn’t it? Am I missing something?

mksd · February 15, 2018, 11:53am

Yes, I think people just never came across it yet.

@ningosi this is typically the kind of discussion that might affect BAH-273. As in: making an inventory of all places that involve Lucene searches.

darius · February 16, 2018, 1:31am

You’re right @shruthipitta I hadn’t noticed that the first link you gave was to openmrs-core code. Possible approaches that occur to me off the top of my head:

Make the max length longer in openmrs-core. (I assume there’s a resource cost for this.)
- could also introduce a similar analyzer with a longer max-length in a Bahmni-specific module. (Same resource cost, but we could decide to do this without any larger discussion)
Stop supporting wildcard identifier searches longer than 20 characters. If the input is too long, just do an exact search.

My (uninformed) vote is for 2.

@mahitha would this limitation be okay for your implementation project?

PS- In fact OpenMRS prefers not to support wildcard searches on identifiers (because identifiers are supposed to be meaningless and wildcard searches make it easier to select the wrong patient).

mahitha · February 16, 2018, 12:00pm

Thanks for asking. We are okay to have this limitation.

darius · February 16, 2018, 8:18pm

@mahitha can you and your team please create a JIRA ticket for this?

mahitha · February 17, 2018, 5:08pm

this is JIRA ticket link