I don't think this method should have been removed

[darius (Darius Jazayeri)]

Continuing the discussion from Backwards compatibility for OpenMRS 2.0 platform Reference Application Modules:

@darius

@dkayiwa

2. EncounterService.getEncounters() was changed from one that takes very many parameters to one that take just one EncounterSearchCriteria parameter.

Are you saying that we removed a non-deprecated EncounterService method when we introduced EncounterSearchCriteria? That sounds like a mistake to me.

Peeking at this commit for TRUNK-4571 I see that the big EncounterService method we used to use for many searches was deprecated, and then I guess since we removed all deprecated methods, it went away.

This method was never deprecated in any released OpenMRS version (only in the master branch) and I don’t actually think we should have deprecated it in the first place. (At least, I don’t think we should have just deprecated that one method until we’ve applied the SearchCriteria pattern across more of the API.)

I vote we bring it back.

[dkayiwa (Daniel Kayiwa)]

Nice catch @darius

Added back at https://github.com/openmrs/openmrs-core/commit/45f652d3cee237e393baf648443937de109158ae

I have also edited our conventions at https://wiki.openmrs.org/display/docs/Coding+Conventions to always include the version when the deprecation happened. That way we shall avoid future removal of methods that have just been deprecated in the same version.