I am not able to do code Reviews I am dev/1

kapil706 · April 4, 2019, 1:59pm

Question:

I have read and watched the OpenMRS university videos but not able to do code reviews as I do not have permission for code Reviews . Please help me with this. Revert me on telegram kapil706 or here Thanks .**

samuel34 · April 4, 2019, 2:07pm

Hi @kapil706

I trust you can do review PullRequests. We don’t expect you to have write/merge privileges in the Openmrs git repo in-order to do reviews. What we actually expect of you is to just approve the pull-requests.

kapil706 · April 4, 2019, 2:08pm

Thanks for clarification but As Also I am not able to approve the pull requests Please help me with this

samuel34 · April 4, 2019, 2:10pm

Do you have a github account?

kapil706 · April 4, 2019, 2:12pm

Yes I do It Is kapil706 . kapil706

samuel34 · April 4, 2019, 2:14pm

Which PR have you tried to review?

kapil706 · April 4, 2019, 2:19pm

this was the PR

samuel34 · April 4, 2019, 2:29pm

Assuming your on the PR page; When you click on files changed link, you will see a widget named “Review changes” It’s green in color. what happens when you click on it?

kapil706 · April 4, 2019, 2:36pm

Thank you so much , Really I just forget that thing. Thanks again !! What is your GitHub profile link buddy ?? slight_smile: