GSoC: Code Reviews a MUST!

Community GSoC
1

This is a gentle reminder to all potential GSoC students that no application will be accepted for any one who has not done code reviews.

Being an open source contributor is not just about fixing bugs and adding new features, but also reviewing other peoples’ contributions.

https://wiki.openmrs.org/display/RES/Summer+Of+Code+2019

12 Likes
2

Thanks for the clarification @dkayiwa , Please GSoC aspirants don’t forget this crucial part.

1 Like
3

Thanks for this information @dkayiwa . Do you have any link on how to review code on github? I don’t know how to use the interface for this activity . And we can do reviews directly or we need to be approved ?

4

o thanks @dkayiwa, am not a GSOC student but i should also improve my self in this matter :grinning:

2 Likes
5

Yeah, that is good. Thanks @dkayiwa :slight_smile:

6

Thanks @dkayiwa for the message :-). Students Please take a look here : https://wiki.openmrs.org/display/RES/Summer+Of+Code+2019#SummerOfCode2019-ApplicationRequirements&Questions

You must include your Pull Requests and Pull Request Reviews in your proposal as a table :-).

Thanks.

1 Like
7

Go to any OpenMRS repo example openmrs-core. Look at PRs and how they are reviewed. The kind of comments that is been left on these PRs. The kind of changes that are been requested. Then also look at the code, look at things you feel are not right with the code and leave a polite comment either requesting for clarification or changes.

You can also get a copy of Clean Code by Uncle Bob :slight_smile:

Use google too, to find out how to review code.

BTW, I learned how to review code mostly by looking at how @dkayiwa reviews and also reading clean code

8

Thanks . With your instructions and the reviews i got on my pull request i managed to review a pull request and request some changes . I hope that i helped the pull request owner.

1 Like
9

And what about " Nigeria Telemedicine App" ? I mean that’s from scratch, how can we contribute ? or you mean in another project ?

10

You can do code reviews on any other module.

11

We don’t want you to review pull requests for your respected projects. You can freely do code reviews in any of the projects in OpenMRS GitHub Repository.

Please make sure that you have understood the language, and the requirements of pull request before making comments :smile:

2 Likes
12

https://openmrs.github.io/openmrs-android-client-user-guide/getting-started.html the below given link is not working so how to view the android app? @suthagar23 @dkayiwa

"### Installation

To install the OpenMRS Android Client on your Android device, head over to Google Play using this link:https://play.google.com/store/apps/details?id=org.openmrs.mobile "

13

Getting started · GitBook the below given link is not working so how to view the android app? @suthagar23 @dkayiwa

"### Installation

To install the OpenMRS Android Client on your Android device, head over to Google Play using this link:https://play.google.com/store/apps/details?id=org.openmrs.mobile "

Cc : @f4ww4z @csmuthukuda

1 Like
14

Hi there, currently our app is temporarily suspended until we submit a privacy policy (it’s actively being worked on as we release the next version of the app) . You can download from our releases page on GitHub at https://github.com/openmrs/openmrs-contrib-android-client/releases for the time being.

2 Likes
15

thank you !

16

how long should be our abstract when we send draft proposal?

17

username and password please

18

@hritikthube follow this Guide for using the App

19

username-admin password - Admin123 doesnt work for the above given link

20

Did you see the README? https://github.com/openmrs/openmrs-contrib-android-client/blob/master/README.md#demo-server