GSoC 2022: Redo Legacy UI Cohort Builder - Project Updates

anjisvj · August 2, 2022, 5:07am

I made the requested changes. can you review again? @jayasanka

anjisvj · August 3, 2022, 2:13pm

Hello, Here’s the PR for improving the tablet and small desktop views.

anjisvj · August 6, 2022, 12:24pm

Hello, Here’s the PR search by drug orders. Since we don’t have the latest reporting module on dev3 this won’t work. I developed this locally.

@dkayiwa can we get the latest update on dev3?

cc: @jayasanka @bistenes

github.com/openmrs/openmrs-esm-cohortbuilder

O3-1306: Implement the search by drug order feature

openmrs:main ← anjula-sack:O3-1306

opened 04:15AM - 06 Aug 22 UTC

anjula-sack

+494 -1

## Purpose - The purpose of this PR is to fix #[O3-1306](https://issues.openm…rs.org/browse/O3-1306) ## Goals - To give the user the ability to search for patients based on their drug usage ## Approach - Created the search by drug orders - Added styles to match the design - Wrote tests - Updated the translations ## Screenshots <img width="893" alt="Screenshot 2022-08-06 at 5 48 39 PM" src="https://user-images.githubusercontent.com/43912578/183248657-f5398a9a-86c6-4634-99e4-8dc390bcc7da.png">

dkayiwa · August 6, 2022, 7:06pm

@anjisvj dev3 is already referencing the latest snapshot version of the reporting module. Which means it should automatically pick up those changes when deployed. And from this CI build plan, the latest deployment happened 3 days ago which should already have your changes: Reference Application - Distribution 3.x 168: Build result summary - OpenMRS Bamboo

anjisvj · August 11, 2022, 7:00am

Hello , Here’s the PR search composition.

A composition query combines together the results of multiple cohorts using the logical operators: AND, OR and NOT.

To use this query you need to already have query results in your search history. Those existing query results can then be combined to yield the results of the composition query.

For example: if search history #1 is a cohort of patients who are males, and if search history #2 is a cohort of patients with ages between 23 and 35 years; then ‘1 AND 2’ will result in a cohort of patients who are males with ages between 23 and 35 years.

cc: @jayasanka @bistenes

github.com/openmrs/openmrs-esm-cohortbuilder

O3-1445: Add search composition feature

openmrs:main ← anjula-sack:O3-1445

opened 05:18PM - 10 Aug 22 UTC

anjula-sack

+277 -5

## Purpose - The purpose of this PR is to fix #[O3-1445](https://issues.openm…rs.org/browse/O3-1445) ## Goals - To give the user the ability to search for patients by combining multiple searches ## Approach - Created the search composition - Added styles to match the design - Wrote tests - Updated the translations ## Screenshots <img width="885" alt="Screenshot 2022-08-11 at 12 02 33 PM" src="https://user-images.githubusercontent.com/43912578/184076590-c5829607-64c4-40cc-8cac-4adcde45bfe0.png">

anjisvj · August 11, 2022, 3:32pm

One of the requirements of this project was to build a scheduler to run the saved cohorts to create an up-to-date patient list for the matching criteria. But we have a solution for this already. Which is the saved queries option. This feature allows you to save only the query definition(without the patients) so that you can run this query to get up-to-date patient lists, which gives a better solution for having the latest patient lists.

Here are the steps you can try yourself. Here’s the link for cohort builder

Create a search

Scroll down to the search history table and select options. Then click save query.

Give it a name
Screenshot 2022-08-11 at 8.57.06 PM1390×766 49 KB
Head over to saved queries (might wanna refresh). The saved query will be there.

From the table select the view option. It will get the latest patient list matching the criteria.

Let me know your thoughts. Thank you!

cc: @grace @jdick @jayasanka @bistenes

jayasanka · August 15, 2022, 2:06pm

Hi Anjula! I think that satisfies the initial requirement and it seems better than using a scheduler.

anjisvj · August 20, 2022, 3:57pm

Thank you @zacbutko for the 4.0 migration PR. After the migration, the UI layout was broken because of the new version of the carbon design. I was working on fixing them and here’s the PR. Can you review this? @jayasanka

Next, I will work on fixing the tests that broke due to this migration. Thank you!

anjisvj · August 21, 2022, 11:11am

Hello, Here’s the PR for fixing the tests that were skipped due to the 4.0 migration

github.com/openmrs/openmrs-esm-cohortbuilder

O3-1472: Fix the tests that were skipped due to the migration

openmrs:main ← anjula-sack:O3-1472

opened 11:03AM - 21 Aug 22 UTC

anjula-sack

+234 -80

## Purpose - The purpose of this PR is to fix #[O3-1472](https://issues.openm…rs.org/browse/O3-1472) ## Goals - To fix the unit tests ## Approach - Fixed the tests that were skipped due to the migration ## Screenshots <img width="414" alt="image" src="https://user-images.githubusercontent.com/43912578/185787978-3ef923ae-72d3-4366-8181-563c5486c96d.png">

anjisvj · August 22, 2022, 4:41pm

Hello everyone! I have some concerns regarding the “Search by SQL Queries” features. One of the main concerns is security(ex: SQL injection). It’s difficult to create an API that covers all the security issues and will be hard to maintain as well.

Another reason is, that this feature cannot be used by someone who doesn’t know SQL and the database schema.

Instead of the SQL query runner, we can extend the search criteria. ex: Search by allergies. Which will be safer and user-friendly.

Let me know your thoughts. Thank you!

cc: @grace @jdick @jayasanka @bistenes

anjisvj · August 23, 2022, 9:17am

Here’s the PR for cohort members not saving issue. can you review this? @dkayiwa

github.com/openmrs/openmrs-module-webservices.rest

RESTWS-897: Fix the cohort members are not saving issue

openmrs:master ← anjula-sack:RESTWS-897

opened 08:20AM - 23 Aug 22 UTC

anjula-sack

+3 -2

## Description of what I changed - Add the cohort members to the return dat…a - Fixed the cohort saving issue ## Issue I worked on see https://issues.openmrs.org/browse/RESTWS-897 ## Checklist: I completed these to help reviewers :) - [x] My pull request only contains **ONE single commit** (the number above, next to the 'Commits' tab is 1). No? -> [read here](https://wiki.openmrs.org/display/docs/Pull+Request+Tips) on how to squash multiple commits into one - [x] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project. No? Unsure? -> [configure your IDE](https://wiki.openmrs.org/display/docs/How-To+Setup+And+Use+Your+IDE), format the code and add the changes with `git add . && git commit --amend` - [ ] I have **added tests** to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) No? -> write tests and add them to this commit `git add . && git commit --amend` - [x] I ran `mvn clean package` right before creating this pull request and added all formatting changes to my commit. No? -> execute above command - [x] All new and existing **tests passed**. No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. - [x] My pull request is **based on the latest changes** of the master branch. No? Unsure? -> execute command `git pull --rebase upstream master`

jayasanka · August 31, 2022, 4:26am

I agree with you @anjisvj ! We need to further validate the requirement. I think it would be better if we could move it to the outer scope and polish up the current features.

anjisvj · September 5, 2022, 3:15pm

@dkayiwa drug orders still not working due to the version mismatch I guess. I think it got changed in this discussion. It should be 2.4.* right?

dkayiwa · September 5, 2022, 3:52pm

@anjisvj oh sorry for having misled you. It should have been 9.* instead of 1.9.*.

Feel free to raise another pull request for the same ticket and i will review and merge it immediately.

anjisvj · September 5, 2022, 3:53pm

No worries. @dkayiwa I’ll send a PR ASAP.

anjisvj · September 5, 2022, 3:59pm

Here’s the PR. @dkayiwa

dkayiwa · September 5, 2022, 4:15pm

Reviewed and merged. Thanks @anjisvj for following it up to the very end.

anjisvj · September 8, 2022, 5:35am

Here’s the final evaluation talk post,

anjisvj · September 9, 2022, 6:44am

Hello, I need to add a link to the cohort builder so the user can use it to visit the cohort builder. In the legacy UI it’s in the navigation bar.

In O3 I guess I can add it to the app. menu?

@ibacher @zacbutko @jayasanka

zacbutko · September 9, 2022, 6:53am

This might be a better question for our design team @cduffy and @pauladams. I’m not sure what the goal of the cohort builder is within O3. For my app I was going to have a redirect workflow - a button to take you to the cohort builder and then redirect logic to put you back in the app after - so really in that workflow it wouldn’t need any permanent links. From that regard maybe this is more like “patient registration” resource. But I’ll defer to the experts.