piumal1999
(Piumal Rathnayake)
August 5, 2022, 7:46am
23
2022-08-04T18:30:00Z Update
Created a pull request for adding the esm-openconceptlab-app to the dev3 server. Created the GitHub action workflow.
openmrs:main
← Piumal1999:O3-1442
opened 07:18PM - 04 Aug 22 UTC
## Requirements
- [x] This PR has a title that briefly describes the work don… e, including the ticket number if there is a ticket.
- [x] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide).
- [x] I checked for feature overlap with [**existing widgets**](https://om.rs/directory).
## Summary
Updated the CI workflow by adding the deployment job of esm-admin-openconceptlab-app
Added missing `tools/i18next-parser.config.js` script
Updated file permissions of husky scripts
<!--
Required.
Please describe what problems your PR addresses.
-->
## Screenshots
*None.*
<!--
Optional.
If possible, please insert any screenshots/videos of your changes here.
Don't forget to remove the *None.* above if you do fill this section.
-->
## Issue
https://issues.openmrs.org/projects/O3/issues/O3-1442
<!--
Required if applicable.
If present, please link any related issue here, e.g. "https://issues.openmrs.org/browse/O3-123").
-->
## Other
*None.*
<!--
Optional.
Anything else that isn't covered by one of the sections above.
Don't forget to remove the *None.* above if you do fill this section.
-->
piumal1999:
Remaining work:
Add paginations to the tables
Added pagination for this component. That pull request will be ready for review after adding the tests
piumal1999
(Piumal Rathnayake)
August 10, 2022, 4:29pm
24
2022-08-09T18:30:00Z Update
I completed the previous-imports component which displays the list of import actions done using the module.
This pull request is ready for review now.
openmrs:main
← Piumal1999:O3-1384
opened 07:23PM - 02 Aug 22 UTC
## Requirements
- [x] This PR has a title that briefly describes the work don… e, including the ticket number if there is a ticket.
- [x] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide).
- [x] I checked for feature overlap with [**existing widgets**](https://om.rs/directory).
## Summary
Created a component which displays the list of previous imports done using the module
<!--
Required.
Please describe what problems your PR addresses.
-->
## Screenshots
https://user-images.githubusercontent.com/27498587/183961789-4fd34d9c-9541-4166-a848-87796d0304c3.mov
<!--
Optional.
If possible, please insert any screenshots/videos of your changes here.
Don't forget to remove the *None.* above if you do fill this section.
-->
## Issue
https://issues.openmrs.org/browse/O3-1384
<!--
Required if applicable.
If present, please link any related issue here, e.g. "https://issues.openmrs.org/browse/O3-123").
-->
## Other
*None.*
<!--
Optional.
Anything else that isn't covered by one of the sections above.
Don't forget to remove the *None.* above if you do fill this section.
-->
Preview:
Updated the deployment pull request as well
1 Like
piumal1999
(Piumal Rathnayake)
August 18, 2022, 9:20pm
25
2022-08-17T18:30:00Z Update
Sent the pull request for fixing the errors occurred due to the React18 CarbonV11 upgrade. - Merged
openmrs:4.0
← Piumal1999:O3-1468
opened 05:43PM - 17 Aug 22 UTC
## Requirements
- [x] This PR has a title that briefly describes the work don… e, including the ticket number if there is a ticket.
- [x] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide).
- [x] I checked for feature overlap with [**existing widgets**](https://om.rs/directory).
## Summary
Some components were breaking due to the Carbon V11 upgrade. Fixed those errors with this Pull request.
<!--
Required.
Please describe what problems your PR addresses.
-->
## Screenshots
*None.*
<!--
Optional.
If possible, please insert any screenshots/videos of your changes here.
Don't forget to remove the *None.* above if you do fill this section.
-->
## Issue
https://issues.openmrs.org/browse/O3-1468
<!--
Required if applicable.
If present, please link any related issue here, e.g. "https://issues.openmrs.org/browse/O3-123").
-->
## Other
*None.*
<!--
Optional.
Anything else that isn't covered by one of the sections above.
Don't forget to remove the *None.* above if you do fill this section.
-->
piumal1999
(Piumal Rathnayake)
August 18, 2022, 9:29pm
26
I identified a few more errors related to items(concepts/mappings) in an import.
These are the known errors which can occur when importing concepts :
Cannot create concept conceptUuid
. Datatype conceptDataType
is not supported by OpenMRS.
This error occurs if the datatype of the concept is not supported.
Cannot import concept conceptUuid
, tried: logError
.
This error is thrown when there is a duplicate concept name error or due to failures in openmrs concept service. The logError
varies with the scenario. So the error message can be very long sometimes.
The following are the known errors which can occur when importing mappings :
Cannot create mapping from concept with URL fromConceptUrl
, because the concept has not been imported.
This occurs when the fromConcept required for the mapping is missing from the OpenMRS instance.
Cannot create mapping for oclMappingURL
as no from concept is defined.
This is thrown when the mapping is incomplete (fromConcept
is missing)
Cannot create mapping from concept with URL toConceptUrl
, because the concept has not been imported.
This occurs when the toConcept required for the mapping is missing from the OpenMRS instance
Cannot create mapping for oclMappingURL
as no to concept is defined.
This is thrown when the mapping is incomplete (toConcept
is missing)
I think most of these are already simplified, so I’ll focus more on the errors that fails the whole import.
Examples:
HTTP/1.1 208 Already Reported caused by: java.io.IOException: HTTP/1.1 208 Already Reported
HTTP/1.1 204 No Content Error caused by: java.io.IOException: …
HTTP/1.1 404 Not Found Error caused by: java.io.IOException: …
There is no release version of the given source…
(Reference - Unable to import concepts using OCL Subscription Module )
1 Like
piumal1999
(Piumal Rathnayake)
August 25, 2022, 4:31pm
27
The module is now deployed on the dev3 server. It can be accessed from this URL → https://dev3.openmrs.org/openmrs/spa/ocl
Feel free to try it yourself and let me know if there are any suggestions.
1 Like
piumal1999
(Piumal Rathnayake)
August 26, 2022, 6:45pm
28
Fixed 2 minor issues. Please review and merge.
openmrs:main
← Piumal1999:O3-1474
opened 04:23PM - 25 Aug 22 UTC
## Requirements
- [x] This PR has a title that briefly describes the work don… e, including the ticket number if there is a ticket.
- [x] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide).
- [x] I checked for feature overlap with [**existing widgets**](https://om.rs/directory).
## Summary
The checkboxes in advanced options were not working after the carbon v11 upgrade. The error was caused by a change in `onChange` prop signature [(v11.md#checkbox)](https://github.com/carbon-design-system/carbon/blob/main/docs/migration/) . Fixed the issue by updating the handlers.
<!--
Required.
Please describe what problems your PR addresses.
-->
## Screenshots
*None.*
<!--
Optional.
If possible, please insert any screenshots/videos of your changes here.
Don't forget to remove the *None.* above if you do fill this section.
-->
## Issue
https://issues.openmrs.org/browse/O3-1474
<!--
Required if applicable.
If present, please link any related issue here, e.g. "https://issues.openmrs.org/browse/O3-123").
-->
## Other
*None.*
<!--
Optional.
Anything else that isn't covered by one of the sections above.
Don't forget to remove the *None.* above if you do fill this section.
-->
openmrs:main
← Piumal1999:O3-1465
opened 06:18PM - 26 Aug 22 UTC
## Requirements
- [x] This PR has a title that briefly describes the work don… e, including the ticket number if there is a ticket.
- [x] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide).
- [x] I checked for feature overlap with [**existing widgets**](https://om.rs/directory).
## Summary
The UI should not allow choosing a snapshot version of a OCL subscription is the version is already defined. So the URL is validated and the subscribeToSnapshot checkbox is enabled/disabled according to that.
Referred to [this](https://github.com/openmrs/openmrs-module-openconceptlab/blob/caed41af5f0b32d398cce1b43a10f5b4a57e73d9/owa/app/js/subscription/subscription.controller.js#L59) when working on this issue.
## Screenshots
When the version is given with the URL:
<img width="80%" alt="image" src="https://user-images.githubusercontent.com/27498587/186966981-6023db42-173b-436b-ad01-1faef8655e09.png">
When the version is not provided:
<img width="80%" alt="image" src="https://user-images.githubusercontent.com/27498587/186967086-22572c54-9cd7-4e20-a1b8-8958a541dc53.png">
<!--
Optional.
If possible, please insert any screenshots/videos of your changes here.
Don't forget to remove the *None.* above if you do fill this section.
-->
## Issue
https://issues.openmrs.org/browse/O3-1465
<!--
Required if applicable.
If present, please link any related issue here, e.g. "https://issues.openmrs.org/browse/O3-123").
-->
## Other
*None.*
<!--
Optional.
Anything else that isn't covered by one of the sections above.
Don't forget to remove the *None.* above if you do fill this section.
-->
cc: @ibacher