GSoC 2020 : Upgrade Platform Core Libraries Project

Community GSoC
, ,
23

I drop the database, the runtime properties file does not even exist. but even so far its not working. @dkayiwa

24

Delete the runtime properties file like how @dkayiwa said and run a flesh,Again i which version of mysql are you running, orelse Share your full logs in pastebin.com

25

@achilep can you try running with this standalone package ??
https://ci.openmrs.org/build/result/artifactUrlRedirect.action?planKey=REFAPP-OMODDISTRO&buildNumber=9977&artifactName=referenceapplication-standalone-snapshot

26

@mozzy please what are the step ? thanks

27

just download that package , you extract it ,

then see https://wiki.openmrs.org/display/docs/OpenMRS+2.x+Standalone+Installation+instructions+-+For+Dummies+version

1 Like
28

@mozzy how do i use it to test the changes i’m making on the openmrs-core ? thanks

29

you simply replace the core war file in that package ,with the core war file you have built/compiled. the file should be under tomcat/webapps

1 Like
30

hello @dkayiwa @ibacher @mozzy @sharif i have completed 9 sub-task on this Ticket .please i need some code review .thanks

1 Like
31

great work , ill drop some comments.

better if you can list the Prs here

1 Like
32

Thanks @achilep for the work you are doing. Can you test each library upgrade by running it with the reference application? You can download the reference application modules from here: https://ci.openmrs.org/build/result/artifactUrlRedirect.action?planKey=REFAPP-OMODDISTRO&buildNumber=9990&artifactName=referenceapplication-addons-snapshot

2 Likes
33

Ok ,thanks @dkayiwa i will retest all the library with the reference application .

34

thanks @dkayiwa i saw some PR were merged, thanks i will collect all the other one, and post its here . thank you

1 Like
35

I’m still testing the others.

36

@dkayiwa has merged some of the tickets so i think will make you go ahead thanks to @dkayiwa

1 Like
37

I was doing some research on the task below.

migrate to use JPA instead of raw Hibernate. The rationale for this is less to enable supporting other JPA providers and more because Hibernate’s new feature development is primarily focused on being a proper implementation of the JPA spec. So, for example JQL gets more attention than HQL these days and the Hibernate Criteria API has been “deprecated” in favour of the JPA version (it’s not going away anytime soon; it’s just not receiving new features).

and here is what I could find

The migration of this project consists of following steps:

1 Entirely remove Hibernate dependency from the Maven con- figuration file.

2.Modify Spring configuration files to bootstrap the JPA entity manager factory instead of the Hibernate session factory.

3.Change Hibernate-specific entity annotations.

4.Replace classes from the native Hibernate API, such as Query or Session , with its standard counterparts.

5Rewrite HQL queries because their syntax in some aspects dif- fers from the JPA QL.

6.Create persistence.xml configuration file and properly define a new persistence unit and its properties.

I don’t know what you think about it. please i need your opinion.thanks @ibacher @mozzy @dkayiwa @burke @mozzy @sharif @herbert24

1 Like
38

hello please i am still working on this PR :

if I manage to get through this problem then I could finish the conversion of the tests

1

@Rule
public TemporaryFolder folder= new TemporaryFolder();

2

@RunWith(PowerMockRunner.class)

public abstract class BaseContextSensitiveTest extends AbstractJUnit4SpringContextTests

The TemporaryFolder does not exist and has no equivalence in junit 5.

Is the same problem with PowerMockRunner there is not PowerMockExtension in junit 5.

for this one AbstractJUnit4SpringContextTests ,i try to use jupiter.SpringExtension but i did not succeed .

any help will be welcome.

thanks @ibacher @mozzy @sharif @dkayiwa @burke @teleivo

39

Hi,

thanks a lot for your work on this so far :slight_smile:

  1. Have you looked at https://junit.org/junit5/docs/current/user-guide/#writing-tests-built-in-extensions-TempDirectory I believe that would be the equivalent of TemporaryFolder.

Another thing we could do which is what I was wondering: if you look at https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4-rule-support we could depend on the migration package junit-jupiter-migrationsupport. This would allow us to gradually migrate. So maybe we would be closer to merge you first commit with this. And then gradually remove the @EnableRuleMigrationSupport from tests relying on for example TemporaryFolder.

Currently the PR is pretty big. So I would suggest to try to keep it smaller. So we do not accidentally break anything.

  1. RunWith is replaced with ExtendWith so there should be a different Runner coming from PowerMock that implements the Junit Jupiter exention. I have not checked though.

  2. For BaseContextSensitiveTest I would need to spend more time looking into what your current issue is.

Hope that helps at least a bit for some of the issues. Please let me know :slight_smile:

3 Likes
40

thank you @teleivo , since yesterday I am actually making good use of your advice, its helped me a lot, I have arrange the PR as you commented, I agree that we merge the work that has already done so far before we can continue.

@dkayiwa @mozzy @ibacher @sharif

1 Like
41

I currently have a problem on updating this library org.glassfish.jaxb:jaxb-runtime:2.3.2 --> 3.0.0-M4 , I use java 8 in my computer and its build without problem, when I push online java 8 build without problem but java 9,10.11 , 12,13, and 14 gives me this error: https://pastebin.com/raw/ufYniyEJ ,

this is the PR :https://github.com/openmrs/openmrs-core/pull/3250

cc @ibacher , @mozzy , @sharif ,

42

@achilep I think you need to add this dependency:

<dependencies>
    <dependency>
        <groupId>jakarta.xml.bind</groupId>
        <artifactId>jakarta.xml.bind-api</artifactId>
        <version>2.3.3</version>
    </dependency>
</dependencies>

See here. Incidentally, we might see if things work using the com.sun.xml.bind:jaxb-impl artifact named there as that, rather than the Glassfish implementation, appears to be the reference implementation for JAX-B now.

3 Likes