Gsoc 2019: Bootstrap as a foundation for Reference Application UI Project

@ayesh Nope my local dev server, which has pulled the latest versions of the snapshots

qa-refapp is still behind on builds

Hmm In my local things are working fine @ssmusoke

bit weired

@dkayiwa I found the root cause of the breaking build, here is a PR to fix it - happened when releasing the reference application module 2.9.1 next update was 2.9.2-SNAPSHOT instead of 2.10.0-SNAPSHOT

2 Likes

Youre awesome as always @ssmusoke :heart:

2 Likes

@ssmusoke @ayesh could you look into why it is still failing?

Hi @dkayiwa

I found two issues

  1. One new div introduced and xpath cant find out the inner table becasue of that selenium test fails
  2. Because of old jquery version bootstrap getting conflicted and backdrop get the page covered so popups get blocked and then selenium test cases fails.

Btw I pushed the fixes after @ssmusoke approve the changes will run a c build again

@ayesh I have reviewed and merged the Pull requests, however there are some selenium failures that would be good for you to look into which may have changed an example are https://travis-ci.org/openmrs/openmrs-distro-referenceapplication/jobs/584071497

The popup issue for start visit has been issued

Hi @ssmusoke

Stephe yes I know have fixed it as well I am sending the fix now to distro.

In the mean time can u review this 2 pr’s

these are 2 fixes for selenium issue.As I figured out it happens becuase as we figured out there are popups coverd by backdrops because of the jqeury issue.So selenium can’t access them this is the reason for these failures.

And this is the version update of snapshots stephe as requested yesterday

Hi @ssmusoke

I pushed the selenium test case fix to this pr as well.But the problem is it’s getting stoped in the middle not because of an error but it’s getting stopped any idea.

@ssmusoke

It’s failing again :expressionless: my bad I didn’t update allergy ui to latest snapshot on the distro pom file. Allergy ui module came up later when looking for test failures.

https://travis-ci.org/openmrs/openmrs-distro-referenceapplication/jobs/584163948

But good thing is I can see few failed test cases passing now

@ayesh these things happen - do send an updated PR for the distro

Hi @ssmusoke

Sure will send stephe caught up in a meeting will send soon.

Btw I found another issue in Accounts page @ssmusoke

There is a bootstrap class conflict here. When clicking on edit providers and user account details page is breaking like below.

Hi @ssmusoke

I sent this 2 PR

  1. For above error fix. https://github.com/openmrs/openmrs-module-adminui/pull/56

  2. Update allergy ui to latest snapshot in distro app https://github.com/openmrs/openmrs-distro-referenceapplication/pull/258

Hi @ssmusoke

Seems like the travis cause an issue can we replay the last build since it failing

https://ci.openmrs.org/browse/REFAPP-OMODDISTRO-INTTESTS-9050/log

@ayesh I was thinking the same thing, had restarted travis ci

https://travis-ci.org/openmrs/openmrs-distro-referenceapplication/builds/584258630

@ayesh The failing tests are

  • editProviderTest
  • verifyModulesAvailableOnHomePage from org.openmrs.reference.LoginTest

Hi @ssmusoke

Stephe I think editProvider test is passing in the end

If you look at the last few lines in the 2nd run it passes and it was a timeout issue https://travis-ci.org/openmrs/openmrs-distro-referenceapplication/jobs/584258632.

Login page test failure fix is below

@ayesh and the build is green

2 Likes

:star_struck::heart_eyes:

Finally yesss :grinning:

2 Likes