I also haven’t looked at the video yet, so if my questions are answered there just let me know and I’ll make sure I watch it before asking further questions…
Hi @mogoodrich
Nope the video was on the fixed issue on the patient register page.
Hello @ayesh, I see that this PR is breaking some functionality in coreapps.
- Its breaking the condition list functionality: https://qa-refapp.openmrs.org/openmrs/coreapps/conditionlist/manageConditions.page?patientId=41d874f3-1d34-4e69-863c-cdac025d00ba&
- Tabs on the home page are not uniform: https://qa-refapp.openmrs.org/openmrs/
Could you please get them fixed. Thank you
fyi: @ssmusoke @jwnasambu
Hi @haripriya
Thank you for pointing out the issue.I already figured it out will be sending the PR for the fixes thank you.It was not in coreapps module it was in appui module a jquery conflict.
Regards Ayesh
cc @ssmusoke
Hi @ssmusoke
I think in then next few weeks will be able to hear about the breaking changes.For an example like the one @haripriya mentioned.And I will work on them as soon as possible
@ayesh yes indeed that is the idea of open source
Release early, release often so that we can have short feedback cycles
Do keep an eye out I am happy to review on issue resolution
@dkayiwa Do we have to create issues for each of these breaks as we find them?
I thought that you would just use the same existing original ticket.
Yes for now I have used the same ticket to proceed with the bugs and sent the PR.
Ayesh
Cool that works and simplifies the process
@ayesh FYI the style guide https://demo.openmrs.org/openmrs/uicommons/styleGuide.page needs to be updated