Sorry, I probably should have weighed in earlier, but can we go back and cut releases of any modules before merging in these changes? I’m definitely looking forward to improving the layout via bootstrap, but the PIH EMR is currently running on the latest snapshot of Core Apps and UI Commons and the recent commits have introduced some issues into our build. We’ve discovered a couple so far: the format of the visit dashboard is now one column… was this intentional? And also date validation during patient registration is failing, I suspect because the one-question-per-screen date validator references date fields via id and/or class and maybe something was lost when bootstrap tags were added.
Anyway, I’m willing to work through these issues, and in the long run a well-laid-out bootstrap design will certainly be an improvement, but it would be great if someone could go back to the commit prior to the merges and do a release so we have a stable version prior to the merges we can use in the short-to-mid term while we test the versions with the bootstrap changes?
Ah, okay, thanks @ayesh! I still think it would be great to cut golds of all the releases prior to the merge. What is other modules still have outstanding merges to be made? I saw there is a PR against appointmentschedulingui, but that shouldn’t affect these pages.
@mogoodrich but as u mentioned patient register page template is not right am working on it currently.Will push up the changes to the demo server when it’s done.
(We also might need to go some custom work to get it working with the PIH EMR, which is totally fine, but would be great to have released versions of all modules with up-to-date changes before the modules are merged in so we don’t have to fix ASAP).
@mogoodrich That is my bad on not releasing the versions of the modules, I was aware there would be some downstream effects, but I had not thought about releasing first.
Next steps: tomorrow I will revert the current bootstrap merges, release, before merging the Pull requests
@ayesh FYI you will need to create new pull requests tomorrow again.
Well @dkayiwa is right in the sense that it’s the best of both worlds if you commit the changes directly but then quickly revert them… so we know immediately that there are issues we will need to resolve, but it doesn’t become a blocker…
Sweet, thanks @ssmusoke and @ayesh! Our build is passing again.
I can try a “controlled” upgrade to the PIH EMR in the future. One issue though… we are not using the Reference Application module but have our own top-level styling in a “PIH” module. I can look closer at the Ref App module changes, but any sense if there some modifications we would need to make to our own styling? After merging the changes to coreapps and ui commons the clinicial dashboard was showing as a single column as you saw in the image above. Maybe the appui modules would fix that, but I’m guessing we might need to make some changes to our own styling config?
