If you look on the ticket’s description, I pointed to an example from another resource (ProviderResource), the short answer is that everything will happen in AttachmentResource1_10 with unit tests in AttachmentController1_10Test.
Btw making Attachments RESTful will also require to document its REST API via Swagger. See here for more about this topic: ‘Documenting REST Resources’.
Yes, i am using the latest snapshot of attachment module.And I saw that it use rest URL to upload the image but still, debugger go through that previous controller? That’s why I got confused.
I haven’t used the SDK in a while but I would assume that it is able to automatically fetch the latest snapshots from the distribution that it puts together.
For this to happen the module should probably be under watch or something, see ‘Watching projects’ in ‘OpenMRS SDK’.
@ridmal good catch! Could you temporarily change the requested mapping on AttachementsController and confirm that it isn’t used anymore?
@zouchine, as part of ATT-4, it will be necessary to change the URL mapping of AttachementsController. You may introduce new constants such as LEGACY_UPLOAD_ATTACHMENT_URL.
I send a PR for relating the ATT-24 issue without any test functions. (Just to clarify I am following the correct path ) .Can you review it and send me some feedback.
@mksd The issue you (@ridmal)are dealing with is claimed by another contributor. According to the guidelines found here you should work on an issue that is assigned to you. We appreciate your eagerness but it is important to follow the manners.
sorry for the inconvenience. Actually, i assigned my self for that issue in a few times back ,since the assignee follows a different task. Then he assigned again while I am working on that. sorry, i didn’t follow the procedure. And sorry @madushan, who was the assignee when I am sent the PR. It won’t happen again.